Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Oct 2000 21:52:18 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Matthew Jacob <mjacob@feral.com>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp <phk@FreeBSD.org>, Greg Lehey <grog@lemis.com>
Subject:   Re: Making work for others (was: cvs commit: src/sys/sys mutex.h
Message-ID:  <XFMail.001024215218.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.21.0010242143210.5645-100000@beppo.feral.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 25-Oct-00 Matthew Jacob wrote:
> 
>> >   Modified files:
>> >     sys/sys              mutex.h
>> >   Log:
>> >   Generate LOTS of warnings to remind the SMPng crew to fix the curproc
>> >   UP/SMP issue.
>> 
>> Is this necessary?  Making work for other people isn't the way to go.
>> If you find the problem objectionable, do what others do and fix it.
> 
> Naw, I think he did the right thing. The warnings aren't that bad.

I prefer the warnings to attempting to fix the problem as the fix would
have to be backed out later, whereas the warnings will go away on their
own once it is properly fixed with PCPU_GET().

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001024215218.jhb>