Date: Thu, 29 Jan 2015 16:00:07 +0000 From: "gnn (George Neville-Neil)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Requested Changes To] D1697: sfxge: Expect required init_state on data path and in periodic calls Message-ID: <ef05ae99b55caabba504d4938f15ad9f@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-hutuusvlrz6sglistgnd-req@FreeBSD.org> References: <differential-rev-PHID-DREV-hutuusvlrz6sglistgnd-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
gnn requested changes to this revision. gnn added a comment. This revision now requires changes to proceed. __predict_false rarely, if ever, does the right thing. Have you run any benchmarks to show that this improves performance? REVISION DETAIL https://reviews.freebsd.org/D1697 To: arybchik, gnn Cc: freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ef05ae99b55caabba504d4938f15ad9f>