Date: Thu, 21 Dec 2006 15:59:15 +0000 From: Coleman Kane <cokane@cokane.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: freebsd-current@freebsd.org, Coleman Kane <cokane@freebsd.org> Subject: Re: UFS_GJOURNAL and ufs.ko Message-ID: <20061221155915.GA28845@ramen.coleyandcheryl> In-Reply-To: <20061221044859.GB63112@comp.chem.msu.su> References: <20061218153906.GA6910@ramen.coleyandcheryl> <20061221044859.GB63112@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
I seem to remember that not working properly for me in this case... but I'll give it another try and let you know. On Thu, Dec 21, 2006 at 07:48:59AM +0300, Yar Tikhiy wrote, and it was proclaimed: > On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote: > > Hello, > > > > I have noticed (since adding UFS journal support) that the > > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel > > module. I've been using this (out of an effort to test as > > much as possible as KLDs) and every time I upgrade my kernel > > I must manually add -DUFS_GJOURNAL to the CFLAGS line in > > its Makefile. > > > > Is there any specific reason why this can't be committed? > > So far, my experience with GJOURNAL has been great testing > > it both with journal+fs on the same device as well as on > > two seperate devices. > > > > It looks like an oversight to me, but I don't want to jump > > the gun on it if there is some reasonable argument to keep > > it out "by default". > > If I understand you right, you run a custom kernel w/o UFS and load > the latter as a module, don't you? If so, just add "options > UFS_GJOURNAL" to your kernel config file, and the module should > pick up the setting from the kernel build directory then, granted > you build modules with the kernel, not with the world. > > IMHO CFLAGS should go away from ufs.ko's Makefile because the module > should get SOFTUPDATES and UFS_DIRHASH from the kernel configuration, > too. > > -- > Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061221155915.GA28845>