Date: Sun, 23 Sep 2012 19:56:06 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Berislav Purgar <bpurgar@gmail.com> Cc: Lev Serebryakov <lev@freebsd.org>, freebsd-wireless@freebsd.org Subject: Re: broken TX in HEAD (AR5212) Message-ID: <CAJ-Vmonrps2A_zk2b5E0paMq7pm5j-=wZq4oBCxbK-bBnvyogg@mail.gmail.com> In-Reply-To: <CAAUsrB5TG3zY10Eabs0AQ3j%2BgMMh0%2BuGvsTVyqNUhxdyfiJtxw@mail.gmail.com> References: <CAAUsrB4tG=Xy55kF1=oZy-BT%2BqWAPsjFiQJOrdSWO-AZcPJqAw@mail.gmail.com> <CAJ-Vmok=j0gLzWb8rRzi9J_YgLhdZ4xUhbw=hXoSbRfewtYGMw@mail.gmail.com> <1772837970.20120923235212@serebryakov.spb.ru> <CAJ-Vmom=FrQ61eyE8JRwbPsxqYLZAJq6xK5xbhEAcruc9wrwhg@mail.gmail.com> <1316862759.20120924000232@serebryakov.spb.ru> <CAAUsrB5TG3zY10Eabs0AQ3j%2BgMMh0%2BuGvsTVyqNUhxdyfiJtxw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hm, ok. Change this bit in if_ath_tx.c: - flags = HAL_TXDESC_CLRDMASK; /* XXX needed for crypto errs */ + //flags = HAL_TXDESC_CLRDMASK; /* XXX needed for crypto errs */ + flags = 0; to just flags = HAL_TXDESC_CLRDMASK; See if that works. Hmph. I thought I caught all the filtered frames weirdness. Obviously I didn't.. Oh for gods sake. I know what I did wrong. Yes, do the above for now. I totally screwed up; I thought I had set CLRDMASK correctly for non-aggregate traffic. Ok, here's what I did wrong - I didn't set the CLRDMASK unconditionally for non-aggregate traffic. So the non-11n (non-aggregate path) has it selectively set - but there's no completion handler which is putting the traffic on the filtered frames list and setting the CLRDMASK bit again. So do the above and please, please file a bug with what you've gathered. I'll add this to the email and I'll fix it in -HEAD. Thanks for pointing this out! Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmonrps2A_zk2b5E0paMq7pm5j-=wZq4oBCxbK-bBnvyogg>