Date: Tue, 17 Jul 2001 20:08:05 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Garance A Drosihn <drosih@rpi.edu> Cc: Bruce Evans <bde@zeta.org.au>, John Baldwin <jhb@FreeBSD.org>, Dima Dorfman <dd@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Subject: Re: cvs commit: src/usr.sbin/zic private.h scheck.c zic.c src/us Message-ID: <3B5470F5.115605E6@FreeBSD.org> References: <Pine.BSF.4.21.0107171745520.65013-100000@besplex.bde.org> <p05101005b77a19ecc632@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Garance A Drosihn wrote: > At 5:47 PM +1000 7/17/01, Bruce Evans wrote: > >On Mon, 16 Jul 2001, John Baldwin wrote: > > > It's (realtively) small, so why not move it to contrib/ to make > > > this more obvious? src/gnu is already somewhat off in its own > > > namespace and is already treated as contrib stuff, however, how > > > are committers supposed to know what "magical" parts of > > > src/usr.s?bin/ are actually 3rd party? > > > >By reading the cvs history. > > We want a hard-and-fast rule that people should not casually > change things in /usr/contrib. It's an easy rule to follow. > If we're going to scatter "contrib" stuff all around the CVS > tree, that makes the rule harder to follow. > > If we're not going to move zic into /usr/contrib, then maybe > we could at least add a '/* NOTE */' to the README and the > start of zic.c noting it's "contrib" status. I just looked > at the CVS log for zic.c, for instance, and I must admit that > nothing really jumped out at me saying "DON'T MODIFY THIS!". > > Yes, I see the bit about "merged changes from vendor branch", > but I suspect that would not wave any red flag at me if I > were just looking to modify this source. Why we can't just add src/usr.sbin/zic/FREEBSD-upgrade file, with detailed information about last import into vendor branch, FreeBSD maintainer, author's e-mail and any others related notes. We have similar files for many contributed packages, so why to seek for something new in this case? -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B5470F5.115605E6>