Skip site navigation (1)Skip section navigation (2) 
Date:      09 Mar 2004 12:37:16 +0000
From:      Bin Ren <br260@cam.ac.uk>
To:        freebsd-current@freebsd.org
Cc:        freebsd-hackers@freebsd.org
Subject:   a serious error in sched_ule.c?
Message-ID:  <E1B0gU0-0004ly-9M.--1c41a3d54c4fc50bd9d924e41c4ca767a2f5dfd9@maroon.csi.cam.ac.uk>
next in thread | raw e-mail | index | archive | help 

Hi, all:

I've been reading sched_ule.c and seem to find a serious error:

in 'sched_slice()':

         * Rationale:
         * KSEs in interactive ksegs get the minimum slice so that we
         * quickly notice if it abuses its advantage.

Then, there is:

        if (!SCHED_INTERACTIVE(kg)) {
                .....
                .....
        } else
                ke->ke_slice = SCHED_SLICE_INTERACTIVE;

Then, at the beginning of the file, there is:

#define SCHED_SLICE_INTERACTIVE         (slice_max)


(slice_max) for interactive KSEs???? Either this is a serious mistake or 
I'm seriously missing sth here.

Thanks,
Bin

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1B0gU0-0004ly-9M.--1c41a3d54c4fc50bd9d924e41c4ca767a2f5dfd9>