Date: Wed, 23 May 2007 20:25:06 +0400 From: Ruslan Ermilov <ru@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files.amd64 files.i386 files.pc98 src/sys/modules/linux Makefile Message-ID: <20070523162506.GA82428@rambler-co.ru> In-Reply-To: <200705231545.l4NFjqvV074354@repoman.freebsd.org> References: <200705231545.l4NFjqvV074354@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, May 23, 2007 at 03:45:52PM +0000, Konstantin Belousov wrote: > kib 2007-05-23 15:45:52 UTC > > FreeBSD src repository > > Modified files: > sys/conf files.amd64 files.i386 files.pc98 > sys/modules/linux Makefile > Log: > Fix the dependency for the linux_support.s, explicitely add linux_assym.h. > > Reported by: rwatson > In collaboration with: rdivacky > Sponsored by: Google SoC 2007 > > Revision Changes Path > 1.103 +2 -1 src/sys/conf/files.amd64 > 1.576 +2 -1 src/sys/conf/files.i386 > 1.354 +2 -1 src/sys/conf/files.pc98 > 1.72 +1 -1 src/sys/modules/linux/Makefile > These files would better have an .S extension as they contain preprocessor macros. From gcc.info: : For any given input file, the file name suffix determines what kind of : compilation is done: [...] : : `FILE.s' : Assembler code. : : `FILE.S' : Assembler code which must be preprocessed. Our standard make(1) rules know about this: : $ touch a.s; make -n a.o; rm a.s : as -o a.o a.s : $ touch a.S ; make -n a.o ; rm a.S : cc -O2 -fno-strict-aliasing -pipe -c a.S This doesn't matter much for the kernel build (it provides its own rules to build from .[Ss]), but makes a difference for a module build, if the latter needs to compile some of the assembly. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGVGriqRfpzJluFF4RApd8AJ4xNqnSlFQ27RRYsxOHe+MOCt3gvQCePqr6 7swWGJ8krdhm0tQuIcRTh1E= =dp5h -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070523162506.GA82428>