Date: Tue, 28 Nov 2023 10:49:54 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9b214a66ea87 - main - x11-toolkits/wxgtk32: fix build with lld 17 Message-ID: <CAFDf7UKAXUTTwY7-iDxmdDSMn30nTjK2-S5JJwErr5w=Gc4ZzA@mail.gmail.com> In-Reply-To: <202311091932.3A9JWpBJ065961@gitrepo.freebsd.org> References: <202311091932.3A9JWpBJ065961@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000078f868060b342e76 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dimitry, Will this commit be MFHed to quarterly? Thanks Dimitry Andric <dim@freebsd.org> escreveu no dia quinta, 9/11/2023 =C3=A0(s= ) 19:50: > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D9b214a66ea8788a6da299139decf5= 06a4b4f5ff1 > > commit 9b214a66ea8788a6da299139decf506a4b4f5ff1 > Author: Dimitry Andric <dim@FreeBSD.org> > AuthorDate: 2023-11-09 19:26:44 +0000 > Commit: Dimitry Andric <dim@FreeBSD.org> > CommitDate: 2023-11-09 19:32:02 +0000 > > x11-toolkits/wxgtk32: fix build with lld 17 > > Building x11-toolkits/wxgtk32 with lld 17 results in the following li= nk > errors: > > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxApp::GTKAllowDiagnosticsControl()' failed: symbol not defined > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxFileDialog::AddShortcut(const wxString&, int)' failed: symbol not defi= ned > > Add -Wl,--undefined-version to LDFLAGS to suppress these errors, sinc= e > wxWidgets reuses the same linker version script for all its shared > libraries. > > PR: 273753 > Approved by: blanket (desktop) > MFH: 2023Q4 > --- > x11-toolkits/wxgtk32/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefil= e > index 934fd79c649b..794704329f2a 100644 > --- a/x11-toolkits/wxgtk32/Makefile > +++ b/x11-toolkits/wxgtk32/Makefile > @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=3D--disable-tls > CONFIGURE_ARGS+=3D--disable-precomp-headers > .endif > > +# wxWidgets uses the same linker version script for all its shared > libraries, so > +# some symbols are expectedly undefined. Suppress errors with lld >=3D 1= 7 > due to > +# these undefined symbols. > +LDFLAGS+=3D -Wl,--undefined-version > + > post-build-NLS-on: > @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000078f868060b342e76 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello Dimitry,</div><div><br></div><div>Will this com= mit be MFHed to quarterly?</div><div><br></div><div>Thanks<br></div></div><= br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Dimitry= Andric <<a href=3D"mailto:dim@freebsd.org">dim@freebsd.org</a>> escr= eveu no dia quinta, 9/11/2023 =C3=A0(s) 19:50:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex">The branch main has been updated by dim:<b= r> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D9b214a66ea8788a= 6da299139decf506a4b4f5ff1" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D9b214a66ea8788a6da299139decf506a4b4f5ff1</= a><br> <br> commit 9b214a66ea8788a6da299139decf506a4b4f5ff1<br> Author:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org><br> AuthorDate: 2023-11-09 19:26:44 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org><br> CommitDate: 2023-11-09 19:32:02 +0000<br> <br> =C2=A0 =C2=A0 x11-toolkits/wxgtk32: fix build with lld 17<br> <br> =C2=A0 =C2=A0 Building x11-toolkits/wxgtk32 with lld 17 results in the foll= owing link<br> =C2=A0 =C2=A0 errors:<br> <br> =C2=A0 =C2=A0 =C2=A0 ld: error: version script assignment of 'WXU_3.2.1= ' to symbol 'wxApp::GTKAllowDiagnosticsControl()' failed: symbo= l not defined<br> =C2=A0 =C2=A0 =C2=A0 ld: error: version script assignment of 'WXU_3.2.1= ' to symbol 'wxFileDialog::AddShortcut(const wxString&, int)= 9; failed: symbol not defined<br> <br> =C2=A0 =C2=A0 Add -Wl,--undefined-version to LDFLAGS to suppress these erro= rs, since<br> =C2=A0 =C2=A0 wxWidgets reuses the same linker version script for all its s= hared<br> =C2=A0 =C2=A0 libraries.<br> <br> =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0273753<br> =C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 blanket (desktop)<br> =C2=A0 =C2=A0 MFH:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2023Q4<br> ---<br> =C2=A0x11-toolkits/wxgtk32/Makefile | 5 +++++<br> =C2=A01 file changed, 5 insertions(+)<br> <br> diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefile<= br> index 934fd79c649b..794704329f2a 100644<br> --- a/x11-toolkits/wxgtk32/Makefile<br> +++ b/x11-toolkits/wxgtk32/Makefile<br> @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=3D--disable-tls<br> =C2=A0CONFIGURE_ARGS+=3D--disable-precomp-headers<br> =C2=A0.endif<br> <br> +# wxWidgets uses the same linker version script for all its shared librari= es, so<br> +# some symbols are expectedly undefined. Suppress errors with lld >=3D = 17 due to<br> +# these undefined symbols.<br> +LDFLAGS+=3D=C2=A0 =C2=A0 =C2=A0 -Wl,--undefined-version<br> +<br> =C2=A0post-build-NLS-on:<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/loca= le<br> <br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --00000000000078f868060b342e76--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKAXUTTwY7-iDxmdDSMn30nTjK2-S5JJwErr5w=Gc4ZzA>