Date: Tue, 28 Nov 2023 10:49:54 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9b214a66ea87 - main - x11-toolkits/wxgtk32: fix build with lld 17 Message-ID: <CAFDf7UKAXUTTwY7-iDxmdDSMn30nTjK2-S5JJwErr5w=Gc4ZzA@mail.gmail.com> In-Reply-To: <202311091932.3A9JWpBJ065961@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello Dimitry, Will this commit be MFHed to quarterly? Thanks Dimitry Andric <dim@freebsd.org> escreveu no dia quinta, 9/11/2023 à(s) 19:50: > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=9b214a66ea8788a6da299139decf506a4b4f5ff1 > > commit 9b214a66ea8788a6da299139decf506a4b4f5ff1 > Author: Dimitry Andric <dim@FreeBSD.org> > AuthorDate: 2023-11-09 19:26:44 +0000 > Commit: Dimitry Andric <dim@FreeBSD.org> > CommitDate: 2023-11-09 19:32:02 +0000 > > x11-toolkits/wxgtk32: fix build with lld 17 > > Building x11-toolkits/wxgtk32 with lld 17 results in the following link > errors: > > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxApp::GTKAllowDiagnosticsControl()' failed: symbol not defined > ld: error: version script assignment of 'WXU_3.2.1' to symbol > 'wxFileDialog::AddShortcut(const wxString&, int)' failed: symbol not defined > > Add -Wl,--undefined-version to LDFLAGS to suppress these errors, since > wxWidgets reuses the same linker version script for all its shared > libraries. > > PR: 273753 > Approved by: blanket (desktop) > MFH: 2023Q4 > --- > x11-toolkits/wxgtk32/Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefile > index 934fd79c649b..794704329f2a 100644 > --- a/x11-toolkits/wxgtk32/Makefile > +++ b/x11-toolkits/wxgtk32/Makefile > @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=--disable-tls > CONFIGURE_ARGS+=--disable-precomp-headers > .endif > > +# wxWidgets uses the same linker version script for all its shared > libraries, so > +# some symbols are expectedly undefined. Suppress errors with lld >= 17 > due to > +# these undefined symbols. > +LDFLAGS+= -Wl,--undefined-version > + > post-build-NLS-on: > @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale > > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>Hello Dimitry,</div><div><br></div><div>Will this commit be MFHed to quarterly?</div><div><br></div><div>Thanks<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Dimitry Andric <<a href="mailto:dim@freebsd.org">dim@freebsd.org</a>> escreveu no dia quinta, 9/11/2023 à(s) 19:50:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by dim:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=9b214a66ea8788a6da299139decf506a4b4f5ff1" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=9b214a66ea8788a6da299139decf506a4b4f5ff1</a><br>; <br> commit 9b214a66ea8788a6da299139decf506a4b4f5ff1<br> Author: Dimitry Andric <dim@FreeBSD.org><br> AuthorDate: 2023-11-09 19:26:44 +0000<br> Commit: Dimitry Andric <dim@FreeBSD.org><br> CommitDate: 2023-11-09 19:32:02 +0000<br> <br> x11-toolkits/wxgtk32: fix build with lld 17<br> <br> Building x11-toolkits/wxgtk32 with lld 17 results in the following link<br> errors:<br> <br> ld: error: version script assignment of 'WXU_3.2.1' to symbol 'wxApp::GTKAllowDiagnosticsControl()' failed: symbol not defined<br> ld: error: version script assignment of 'WXU_3.2.1' to symbol 'wxFileDialog::AddShortcut(const wxString&, int)' failed: symbol not defined<br> <br> Add -Wl,--undefined-version to LDFLAGS to suppress these errors, since<br> wxWidgets reuses the same linker version script for all its shared<br> libraries.<br> <br> PR: 273753<br> Approved by: blanket (desktop)<br> MFH: 2023Q4<br> ---<br> x11-toolkits/wxgtk32/Makefile | 5 +++++<br> 1 file changed, 5 insertions(+)<br> <br> diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefile<br> index 934fd79c649b..794704329f2a 100644<br> --- a/x11-toolkits/wxgtk32/Makefile<br> +++ b/x11-toolkits/wxgtk32/Makefile<br> @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=--disable-tls<br> CONFIGURE_ARGS+=--disable-precomp-headers<br> .endif<br> <br> +# wxWidgets uses the same linker version script for all its shared libraries, so<br> +# some symbols are expectedly undefined. Suppress errors with lld >= 17 due to<br> +# these undefined symbols.<br> +LDFLAGS+= -Wl,--undefined-version<br> +<br> post-build-NLS-on:<br> @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale<br> <br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKAXUTTwY7-iDxmdDSMn30nTjK2-S5JJwErr5w=Gc4ZzA>