Date: Sun, 15 Sep 2013 11:45:09 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: java@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, Greg Lewis <glewis@FreeBSD.org> Subject: Re: Building java/openjdk7 with clang Message-ID: <A8D183C4-6C90-4BAD-B052-B39ADDB468DD@FreeBSD.org> In-Reply-To: <20130915060706.GH41229@kib.kiev.ua> References: <108F3771-64B3-40E9-91FA-04C160442608@FreeBSD.org> <20130915060706.GH41229@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Sep 15, 2013, at 08:07, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Sun, Sep 15, 2013 at 01:45:19AM +0200, Dimitry Andric wrote: ... >> - Change the $(CC) -dumpspecs hack in one of the Makefiles to something >> more portable. The -dumpspecs is done to figure out if the compiler >> uses --hash-style=gnu when linking, and if it does, it changes the >> option to --hash-style=both. On FreeBSD, this is basically a no-op, > Compiler ? Do you reference the ELF hash there ? Why do you think this is > nop ? Before your r236137 in head, our gcc did not pass --hash-style at all, afterwards it passes --hash-style=both (for dynamic executables). Similar for our clang, before and after r236258. So grepping for --hash-style=gnu in the verbose output will never give a hit, and the JDK Makefile will never add an explicit --hash-style=both argument. Therefore, for FreeBSD, the whole block is effectively a nop. Maybe the change from -dumpspecs to a small link operation using -v can be sent upstream, so it works for all compilers. -Dimitry --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI1gbAACgkQsF6jCi4glqPOKQCg4z5P2X6cOSefpX4qVxfmKDIH /B0AoPPDyXMv5vk939kDjIkY/YsduqH3 =zUJA -----END PGP SIGNATURE----- --Apple-Mail=_C82A5FEB-637E-43BE-AA7C-B57FCB1E84EF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A8D183C4-6C90-4BAD-B052-B39ADDB468DD>