Date: Mon, 24 Feb 2014 17:59:07 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Antoine Brodin <antoine@FreeBSD.org>, apache@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org> Subject: Re: Patch for devel/apr1 Message-ID: <20140224165906.GE83610@ithaqua.etoilebsd.net> In-Reply-To: <d73YgQvFILY2/L/3172O%2BSqT8sQ@Edl7HbwHujl6CRBF88MhHM/peE4> References: <W/LXQdmArDuvEZINc6uIco1Q77Q@DMnR65URhR2fwN60Ud5mwsygncU> <rPjS0dCkOXQwLs9s6PofV/p/GT4@Edl7HbwHujl6CRBF88MhHM/peE4> <d73YgQvFILY2/L/3172O%2BSqT8sQ@Edl7HbwHujl6CRBF88MhHM/peE4> <329E85FD56E28E496CF7A8D1@ogg.in.absolight.net> <si3TtFF7heojydymL3/cz%2BBr880@W4hAcbyY3boCl2ecg4/u9JA8hSY> <CAALwa8k4785Je3y8JjUzswZ0Z60k6Lu=VJ_XGRfmOAryimSaKQ@mail.gmail.com> <si3TtFF7heojydymL3/cz%2BBr880@W4hAcbyY3boCl2ecg4/u9JA8hSY> <0D910641F7C86C422DB65D4C@ogg.in.absolight.net> <d73YgQvFILY2/L/3172O%2BSqT8sQ@Edl7HbwHujl6CRBF88MhHM/peE4>
next in thread | previous in thread | raw e-mail | index | archive | help
--Oiv9uiLrevHtW1RS
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Feb 24, 2014 at 08:19:21PM +0400, Eygene Ryabinkin wrote:
> Mon, Feb 24, 2014 at 04:43:06PM +0100, Mathieu Arnold wrote:
> > +--On 24 f=E9vrier 2014 19:07:49 +0400 Eygene Ryabinkin <rea@freebsd.or=
g>
> > wrote:
> > |> and doesn't work for options in a group.
> > |=20
> > | Simple fix is attached.
> >=20
> > Hum, there can be no simple fix, the reason it is not supported is that
> > with that, you can break the port by forcing multiple options where only
> > one should be enabled.
>=20
> It works for me with OPTIONS_SINGLE of mutt with
> {{{
> # Mutt
> .if ${.CURDIR:M/usr/ports/mail/mutt}
> BATCH=3Dyes
> WITH_SCREEN=3Dyes
> WITH_NCURSES=3Dyes # SCREEN: single
> WITH_SLANG=3Dyes # SCREEN: single
> WITH_COMPRESSED_FOLDERS=3Dyes
> WITHOUT_DEBUG=3Dyes
> WITHOUT_FLOCK=3Dyes
> WITH_GPGME=3Dyes
> WITHOUT_GREETING_PATCH=3Dyes
> WITHOUT_HTML=3Dyes
> WITH_ICONV=3Dyes
> WITHOUT_IDN=3Dyes
> WITH_IFDEF_PATCH=3Dyes
> WITHOUT_IMAP_HEADER_CACHE=3Dyes
> WITH_LOCALES_FIX=3Dyes
> WITH_MAILBOX_MANPAGES=3Dyes
> WITH_MAILDIR_HEADER_CACHE=3Dyes
> WITH_MAILDIR_MTIME_PATCH=3Dyes
> WITHOUT_NNTP=3Dyes
> WITHOUT_PARENT_CHILD_MATCH_PATCH=3Dyes
> WITH_QUOTE_PATCH=3Dyes
> WITH_REVERSE_REPLY_PATCH=3Dyes
> WITH_SASL=3Dyes
> WITHOUT_SGMLFORMAT=3Dyes
> WITHOUT_SIDEBAR_PATCH=3Dyes
> WITHOUT_SIGNATURE_MENU=3Dyes
> WITH_SMIME_OUTLOOK_COMPAT=3Dyes
> WITH_SMTP=3Dyes
> WITH_TOKYOCABINET=3Dyes
> WITHOUT_TRASH_PATCH=3Dyes
> WITHOUT_XML=3Dyes
> WITHOUT_ASPELL=3Dyes
> WITHOUT_ISPELL=3Dyes
> .endif
> }}}
> I have the proper error,
> {{{
> $ make
> =3D=3D=3D=3D> You must select one and only one option from the SCREEN sin=
gle
> make: exec(exit) failed (No such file or directory)
> *** Error code 1
>=20
> Stop.
> }}}
>=20
> > I've just committed a patch to bsd.options.mk[1] so that it tells
> > you you are using an old way and should update.
>=20
> Well, while this can have its own merits, it is a way too many POLA
> changes and sudden hickups (iconv in base, this change, ld's
> --add-needed change) that make me to collide my head and the
> table/wall.
>=20
You cannot call POLA on something new OPTIONS_GROUP, OPTIONS_RADIO,
OPTIONS_SINGLE, OPTIONS_MULTI are new the maintainer as decided to use the =
new
interfaces because they are more convenient.
The old option framework as moved to OPTIONS_DEFINE and thus we maintain
compatibility for this change (hence the WITH/WITHOUT thing working properly
with OPTIONS_DEFINE options).
All you used to manually do via .if ${.CURDIR...} can be intrument a reliab=
le
way with the new option framework directly and it will work with all OPTION=
S_*
things:
mail_mutt_SET=3D TOKYOCABINET GPGME
mail_mutt_UNSET=3D ASPELL ISPELL
OPTIONS_SET will make it global and it can be overwritten by the specifion:
<cat>_<port>_SET
same goes for unset.
regards,
Bapt
--Oiv9uiLrevHtW1RS
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (FreeBSD)
iEYEARECAAYFAlMLeloACgkQ8kTtMUmk6EwxzACfdCarEJKvU2qlJ51xcYHXGDqR
c/MAoIbZ5dw6hbmr7TTGSEUR6OGi6mL1
=BV+n
-----END PGP SIGNATURE-----
--Oiv9uiLrevHtW1RS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140224165906.GE83610>