Date: Mon, 14 Apr 2003 13:04:06 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: mdodd@FreeBSD.ORG Cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <20030414.130406.104032537.imp@bsdimp.com> In-Reply-To: <20030414124016.O39446@sasami.jurai.net> References: <200304140945.h3E9jPCe005099@repoman.freebsd.org> <20030414.102923.58074053.imp@bsdimp.com> <20030414124016.O39446@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20030414124016.O39446@sasami.jurai.net>
"Matthew N. Dodd" <mdodd@FreeBSD.ORG> writes:
: On Mon, 14 Apr 2003, M. Warner Losh wrote:
: > In message: <200304140945.h3E9jPCe005099@repoman.freebsd.org>
: > Maxim Sobolev <sobomax@FreeBSD.org> writes:
: > : Before attaching device set PCIM_CMD_PORTEN in addition to
: > : PCIM_CMD_MEMEN and PCIM_CMD_BUSMASTEREN, becaise some braindead
: > : BIOSes (such as one found in my vprmatrix notebook) forget
: > : to initialize it properly resulting in attachment failure.
: >
: > Actually, code like this should be the pci bus, since all driver have
: > this issue...
:
: Likely this could be added to the bus_alloc_resource() path... Doing a
: sanity check on requests and then enabling the resource seems like the
: correct solution.
Yes. That's what I had in mind. However, the bus master stuff still
may need to be done in the drivers since I don't think that the
bus_space_dma routines go through newbus at all...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030414.130406.104032537.imp>