Date: Mon, 17 Jul 1995 17:51:20 +0400 (MSD) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" <ache@freebsd.org> To: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com, Peter Wemm <peter@freefall.cdrom.com> Subject: Re: cvs commit: src/usr.bin/more main.c Message-ID: <dBOhc2m4U1@deep-thought.demos.su> In-Reply-To: <199507171237.FAA28276@freefall.cdrom.com>; from Peter Wemm at Mon, 17 Jul 1995 05:37:54 -0700 References: <199507171237.FAA28276@freefall.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199507171237.FAA28276@freefall.cdrom.com> Peter Wemm
writes:
>peter 95/07/17 05:37:52
> Modified: usr.bin/more main.c
> Log:
> Make 'more' sensative to the current locale for it's ctype calls.
> Submitted by: Thomas Gellekum, with minor cosmetic changes from me.
Please, back out this commit.
1) It breaks rune chars totally, more isn't ready to support
chars > 8bits, but tries with this patch!
2) Such functionality ALREDY EXISTS!
Shure, you don't need to add such stuff to each ctype program
even for 8bit chars!
All you need is
setenv ENABLE_STARTUP_LOCALE
for it.
ENABLE_STARTUP_LOCALE is smart enough to not turn it on for 16bit
chars.
BTW,
I suggest that all locale changes need goes through my review
first to avoid such obviosly wrong cases.
--
Andrey A. Chernov :
ache@FreeBSD.org : From 33th IETF
FidoNet: 2:5020/230.3 : Stockholm
RELCOM Team,FreeBSD Team :
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dBOhc2m4U1>