Date: Thu, 19 Feb 2015 07:41:46 +0000 From: "pjd (Pawel Jakub Dawidek)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D1870: Add tests for nvlist_clone Message-ID: <7fed1dc88c3e23fe64ea4dc97923e0a4@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-i4g3nn5qdjs7mg64g7t6-req@FreeBSD.org> References: <differential-rev-PHID-DREV-i4g3nn5qdjs7mg64g7t6-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
pjd added inline comments. INLINE COMMENTS lib/libnv/tests/nv_tests.cc:324-331 Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone, jfvogel Cc: freebsd-net, pjd
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fed1dc88c3e23fe64ea4dc97923e0a4>