Date: Sun, 12 Aug 2007 01:33:14 +0800 From: Xin LI <delphij@delphij.net> Cc: krion@freebsd.org, freebsd-ports@freebsd.org Subject: Re: request add db45/db46 support to mail/exim port Message-ID: <46BDF2DA.8070906@delphij.net> In-Reply-To: <70f41ba20708111013g296134ecw57bf152846718e91@mail.gmail.com> References: <70f41ba20708110931i4262c224kd0479290616c4fa8@mail.gmail.com> <46BDEA06.9030503@delphij.net> <70f41ba20708111013g296134ecw57bf152846718e91@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
snowcrash+freebsd wrote: > hi, > >> Sounds great, just one point: I'd prefer seeing that exim would make use >> of bsd.database.mk. > > i /thought/ that use of WITH_BDB_VER/USE_BDB *is* 'making use of' > bsd.database.mk, wherein, > > ... > .if defined(WITH_BDB_VER) > . if ${WITH_BDB_VER} == 4 > USE_BDB= 40 > . elif ${WITH_BDB_VER} != 1 > USE_BDB= ${WITH_BDB_VER} > . endif > .endif > _WANT_BDB_VER= ${USE_BDB} Em... What I mean is that exim should rely on bsd.database.mk to choose BDB version, if possible. This could be something like: .if !defined(WITHOUT_BDB) WITH_BDB_VER?= 46 USE_BDB= yes .endif DB_INCLUDES= -I${BDB_INCLUDE_DIR} DB_LIBS= -L${LOCALBASE}/lib -l${BDB_LIB_NAME:R} But I do not have some test with it, though... This way, exim will automatically pick up with bsd.database.mk changes. Just my $0.02 :-) Cheers,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46BDF2DA.8070906>