Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Dec 2008 00:42:42 GMT
From:      Paolo Pisati <piso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 154755 for review
Message-ID:  <200812160042.mBG0ggnt055183@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=154755

Change 154755 by piso@piso_newluxor on 2008/12/16 00:42:17

	leave a comment about a bug left in UdpAliasIn: the return code from find_handler() should
	be checked instead of a always 0 variable.

Affected files ...

.. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#86 edit

Differences ...

==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias.c#86 (text+ko) ====

@@ -789,6 +789,7 @@
 		    &original_address, &pip->ip_dst, 2);
 		pip->ip_dst = original_address;
 
+		// XXX should check error instead of r - see pre modules version rev=1.53
 		/*
 		 * If we cannot figure out the packet, ignore it.
 		 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812160042.mBG0ggnt055183>