Date: Tue, 21 Jan 2003 14:45:31 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: Daniel Holmes <danielh@zorkmid.dakcs.com> Cc: freebsd-current@freebsd.org Subject: Re: acpi_cpu printf Message-ID: <3E2DCD8B.91E441A2@mindspring.com> References: <200301211554.h0LFsKmX002682@zorkmid.dakcs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Holmes wrote:
> > + printf("acpi_cpu: throttling enabled, %d steps from 100%% to %d.%d%%, "
> > + "currently %d.%d%%\n"
>
> Personally, rather than 'enabled', how about 'available'? Using the
> word enabled might give some newbies fits when they try to figure it
> out what it means. It sounds like the throttling is already turned on.
I made the same comment, originally; I think that the problem is
that "enabled" is more likely to have meaning for non-English
speakers than "available".
You missed the second "printf", which printed out the current
stepping level; I did too, when I first read it.
I think that changing the order from "100% to 10%" to "10% to 100%"
will, if people ignore the second printed line, imply that there
was a transition from 10% to 100%, rather than the reverse (that
was my response to the patch).
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E2DCD8B.91E441A2>