Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Mar 2003 17:35:49 +0100 (CET)
From:      Martin Blapp <mb@imp.ch>
To:        "Jacques A. Vidrine" <nectar@FreeBSD.org>
Cc:        Martin Blapp <mbr@FreeBSD.org>, "" <src-committers@FreeBSD.org>, "" <cvs-src@FreeBSD.org>, "" <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/contrib/isc-dhcp/client dhclient.c
Message-ID:  <20030324170856.O21003@cvs.imp.ch>
In-Reply-To: <20030324160604.GB1911@madman.celabo.org>
References:  <200303232329.h2NNTaI5089971@repoman.freebsd.org> <20030324160604.GB1911@madman.celabo.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi,

> Are you sure that all values of pid_t can be represented in a signed
> int?

sys/alpha/include/ansi.h:#define        _BSD_PID_T_     int                     /* process [group] */
sys/i386/include/ansi.h:#define _BSD_PID_T_     int                     /* process [group] */
sys/sys/types.h:typedef _BSD_PID_T_     pid_t;          /* process id */

>
> +       pid_t oldpid;
> !                       e = fscanf(pidfd, "%d", &oldpid);
>
> I'd probably opt to do the fscanf with an unsigned long, and then cast
> the value to (pid_t).  *shrug*

or use a unsigned int for it ? Will we have to change this for later ?

Martin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030324170856.O21003>