Date: Sun, 24 Mar 2019 19:34:33 -0600 From: Warner Losh <imp@bsdimp.com> To: Rebecca Cran <rebecca@bluestop.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, "freebsd-arch@freebsd.org" <arch@freebsd.org> Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" Message-ID: <CANCZdfrNSd_eoa933j-ouCHgURqCHCqtv1MQ2PYT1dvAzF0uTQ@mail.gmail.com> In-Reply-To: <6badde15-d8f4-c4ea-2061-0d3c80c6e82a@bluestop.org> References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> <20190324090103.GO1923@kib.kiev.ua> <e6695237-6a22-3ff0-b113-9efeee05a51a@bluestop.org> <20190325000241.GS1923@kib.kiev.ua> <6badde15-d8f4-c4ea-2061-0d3c80c6e82a@bluestop.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 24, 2019 at 6:59 PM Rebecca Cran via freebsd-arch <
freebsd-arch@freebsd.org> wrote:
> On 3/24/19 6:02 PM, Konstantin Belousov wrote:
>
> >
> > Having efi_update_loader alone would be fine, but I doubt that this
> > script can do much except in situations where a lot of pre-assumptions
> > are true. I believe that despite all the efforts put into efibootmgr
> > and installer, it is hard/impossible to make the script not dangerous,
> > except if the whole configuration was created by our installer.
>
>
> It currently does nothing except if there is one or more partitions of
> type 'efi' that contain a \efi\boot\boot${arch}.efi or
> \efi\freebsd\loader.efi that contain strings from the FreeBSD boot1.efi
> or loader.efi. Perhaps that's too much guessing, and we should only ever
> update /boot/msdos or /boot/efi or wherever we decide to mount it.
>
Right. We need a standard location (that maybe can be overridden, like you
can with /boot, if you really want), and that's likely the first order of
business. I don't think we should be second guessing, though. And we
shouldn't be touching \efi\boot anything unless specifically instructed to
do so. I'm deeply uncomfortable with guessing whether or not to do
something...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrNSd_eoa933j-ouCHgURqCHCqtv1MQ2PYT1dvAzF0uTQ>