Date: Tue, 22 Jan 2008 09:51:08 +0800 From: Rong-En Fan <rafan@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Rong-En Fan <rafan@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in Message-ID: <20080122015108.GX4650@svm.csie.ntu.edu.tw> In-Reply-To: <4795044E.6030006@FreeBSD.org> References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> <4795044E.6030006@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote: > Rong-En Fan wrote: >> rafan 2008-01-20 08:37:23 UTC >> >> FreeBSD ports repository >> >> Modified files: >> sysutils/LPRng Makefile distinfo pkg-descr pkg-plist >> sysutils/LPRng/files pkg-message.in Added files: >> sysutils/LPRng/files lprng.in Log: >> - Update to 3.8.32 >> - Provide new rc script > > The script looks good, thanks for doing this! The only thing I would point > out is that the default _enable=no is not needed, since rc.subr needs to > see one of the values for "yes" in order to do anything. No harm leaving it > in, I just wanted to point out that it's not strictly necessary. Thanks. I see most of our /etc/rc.d/* scripts does not have this. But most ports' have as our Porter's Handbook have such example. Regards, Rong-En Fan- > > Doug > > -- > > This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080122015108.GX4650>