Date: 04 Sep 2003 10:06:32 +0100 From: Doug Rabson <dfr@nlsystems.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: "M. Warner Losh" <imp@bsdimp.com> Subject: Re: cvs commit: src/sys/pci if_sis.c if_sisreg.h Message-ID: <1062666391.92763.1.camel@herring.nlsystems.com> In-Reply-To: <1199.1062664515@critter.freebsd.dk> References: <1199.1062664515@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2003-09-04 at 09:35, Poul-Henning Kamp wrote: > In message <1062663414.86530.15.camel@herring.nlsystems.com>, Doug Rabson write > s: > > >For specific drivers, if they really want to change the device > >description in attach (why not do it in probe like every other driver), > > In the case of the sis driver, the "silicon revision register" is > stored somewhere in BAR0, so I cannot examine it until the resources > are allocated. > > I know there are other drivers which could be similarly more detailed > of the description were set in attach rather than probe. > > I think postpoining the print to after attach might make sense. I don't think that can happen for the reasons I just mentioned - drivers which print stuff and drivers which create children.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1062666391.92763.1.camel>