Date: Fri, 23 Aug 2013 17:24:08 +0200 From: Florian Wagner <florian@wagner-flo.net> To: freebsd-stable@freebsd.org Subject: Re: [HEADS UP] change in devfs path matching logic Message-ID: <20130823172408.66ea3280@naclador.mos32.de> In-Reply-To: <52176C7B.4070701@FreeBSD.org> References: <51F28A33.7040209@FreeBSD.org> <52176C7B.4070701@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, 23 Aug 2013 17:06:51 +0300 Andriy Gapon <avg@FreeBSD.org> wrote: > > This change is about to be MFC-ed. > > on 26/07/2013 17:39 Andriy Gapon said the following: > > > > I have just committed a significant change to devfs path matching > > logic http://svnweb.freebsd.org/changeset/base/253677 > > > > Jaakko Heinonen (jh@) has full credit for the code while I have full > > responsibility for any consequences of the commit. > > > > Before this change the logic of matching the devfs paths to the > > patterns in devfs rules was quite arcane. Now this logic should be > > much simpler and logical (sorry for tautology). > > > > Please note that nothing changes with respect to matching simple > > paths like /dev/something. It is the complex paths that involve > > subdirectories that are affected. > > > > I think that if you knew how the old logic worked and were able to > > devise rules for it, then you will have no problem to change those > > rules for the new logic. Just please don't forget to do it when you > > upgrade! > > > > I hope that overall you will find this change to be an improvement. > > > > P.S. I notify stable@ because I currently plan to MFC this change > > after 1 month period. If you know a reason why the MFC should not > > be done, please alert me to it. That MFC is rev 254708, isn't it? Is the MFC complete with that single commit? Because that just broke my (coincidentally made) build: cc1: warnings being treated as errors /build/src/sys/fs/devfs/devfs_rule.c: In function 'devfs_rule_matchpath': /build/src/sys/fs/devfs/devfs_rule.c:592: warning: implicit declaration of function 'devfs_fqpn' /build/src/sys/fs/devfs/devfs_rule.c:592: warning: nested extern declaration of 'devfs_fqpn' /build/src/sys/fs/devfs/devfs_rule.c:592: warning: assignment makes pointer from integer without a cast Whereas rev 254705 builds successfully... Regards Florian [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iEYEARECAAYFAlIXfpgACgkQLvW/2gp2pPzl4ACfZQw58Ahhe+R3PIe795QwG+Ca KmkAnj43ysufs/wukEER9JeZOhvvnLGe =+7z0 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130823172408.66ea3280>