Date: Fri, 12 Oct 2018 01:44:22 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Glen Barber <gjb@freebsd.org>, Justin Hibbits <chmeeedalf@gmail.com> Cc: =?UTF-8?B?UmHDumw=?= <raul@b2n.org>, freebsd-current@freebsd.org Subject: Re: r339289 buildworld stopped in /usr/src/secure/lib/libcrypto Message-ID: <07925544-3158-0812-56b4-6d4346dd8c1f@FreeBSD.org> In-Reply-To: <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org> References: <ca1c05c9-a072-6fc4-4d01-c2cf80c0b1f3@gmail.com> <82f64ae7-2e02-59a7-6058-01b33d594517@b2n.org> <20181011190745.GD53700@FreeBSD.org> <20181011153847.76f256df@ralga.knownspace> <b19c4fe0-9d4a-4594-fa23-c3811438aa82@FreeBSD.org> <20181011164410.6e9a00aa@ralga.knownspace> <20181011223234.GG53700@FreeBSD.org> <20181011225546.GI53700@FreeBSD.org> <20181012005745.GJ53700@FreeBSD.org> <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--G32THXLYXbnk41VhPG9XiagD6sh5IvCrk
Content-Type: multipart/mixed; boundary="hKO69GqRcyIRY37dGKv62DFssCycezqA6";
protected-headers="v1"
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Glen Barber <gjb@freebsd.org>, Justin Hibbits <chmeeedalf@gmail.com>
Cc: =?UTF-8?B?UmHDumw=?= <raul@b2n.org>, freebsd-current@freebsd.org
Message-ID: <07925544-3158-0812-56b4-6d4346dd8c1f@FreeBSD.org>
Subject: Re: r339289 buildworld stopped in /usr/src/secure/lib/libcrypto
References: <ca1c05c9-a072-6fc4-4d01-c2cf80c0b1f3@gmail.com>
<82f64ae7-2e02-59a7-6058-01b33d594517@b2n.org>
<20181011190745.GD53700@FreeBSD.org>
<20181011153847.76f256df@ralga.knownspace>
<b19c4fe0-9d4a-4594-fa23-c3811438aa82@FreeBSD.org>
<20181011164410.6e9a00aa@ralga.knownspace>
<20181011223234.GG53700@FreeBSD.org> <20181011225546.GI53700@FreeBSD.org>
<20181012005745.GJ53700@FreeBSD.org>
<1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org>
In-Reply-To: <1cc5f351-3037-cc9c-00a8-266bd7967314@FreeBSD.org>
--hKO69GqRcyIRY37dGKv62DFssCycezqA6
Content-Type: multipart/mixed;
boundary="------------879ECB888FA72F86F1E30151"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------879ECB888FA72F86F1E30151
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 18. 10. 12., Jung-uk Kim wrote:
> On 18. 10. 11., Glen Barber wrote:
>> On Thu, Oct 11, 2018 at 10:55:46PM +0000, Glen Barber wrote:
>>> On Thu, Oct 11, 2018 at 10:32:34PM +0000, Glen Barber wrote:
>>>> I still see a failure with this applied.
>>>>
>>>> =3D=3D=3D> lib/libldns (obj,all,install)
>>>> /usr/obj/usr/src/powerpc.powerpc/tmp/usr/bin/ld: cannot find -lssl
>>>> --- libprivateldns.so.5.full ---
>>>> *** [libprivateldns.so.5.full] Error code 1
>>>>
>>>> I'll prune .OBJDIR and re-run without -jN to eliminate the possibili=
ty
>>>> of a build race.
>>>>
>>>
>>> It does not appear to be a build race.
>>>
>>> =3D=3D=3D> secure/lib/libcrypto (obj,all,install)
>>> /usr/src/crypto/openssl/crypto/err/err.c: In function 'err_load_stri=
ngs':
>>> /usr/src/crypto/openssl/crypto/err/err.c:311: warning: passing argum=
ent 2 of 'lh_ERR_STRING_DATA_insert' discards qualifiers from pointer tar=
get type
>>> /usr/src/crypto/openssl/crypto/err/err.c: In function 'err_load_stri=
ngs':
>>> /usr/src/crypto/openssl/crypto/err/err.c:311: warning: passing argum=
ent 2 of 'lh_ERR_STRING_DATA_insert' discards qualifiers from pointer tar=
get type
>>> /usr/obj/usr/src/powerpc.powerpc/tmp/usr/bin/ld: cannot find -lpthre=
ad
>>> *** Error code 1
>>> =20
>>> Stop.
>>> make[4]: stopped in /usr/src/secure/lib/libcrypto
>>> *** Error code 1
>>>
>>
>> In fact, on closer inspection, this patch breaks every architecture.
>=20
> I forgot to patch one more file, i.e., Makefile.inc1. Please try the
> attached patch instead.
Darn, I attached an incomplete patch. This should be final.
Sorry about the brain farts. I need some sleep. :-(
Jung-uk Kim
--------------879ECB888FA72F86F1E30151
Content-Type: text/x-patch;
name="ldns.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="ldns.diff"
Index: Makefile.inc1
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- Makefile.inc1 (revision 339324)
+++ Makefile.inc1 (working copy)
@@ -2534,8 +2534,8 @@ _prebuild_libs=3D ${_kerberos5_lib_libasn1} \
${_cddl_lib_libctf} \
lib/libufs \
lib/libutil lib/libpjdlog ${_lib_libypclnt} lib/libz lib/msun \
- ${_secure_lib_libcrypto} ${_lib_libldns} \
- ${_secure_lib_libssh} ${_secure_lib_libssl}
+ ${_secure_lib_libcrypto} ${_secure_lib_libssl} \
+ ${_lib_libldns} ${_secure_lib_libssh}
=20
.if ${MK_GNUCXX} !=3D "no"
_prebuild_libs+=3D gnu/lib/libstdc++ gnu/lib/libsupc++
@@ -2631,9 +2631,10 @@ lib/librtld_db__L: lib/libprocstat__L
_secure_lib_libcrypto=3D secure/lib/libcrypto
_secure_lib_libssl=3D secure/lib/libssl
lib/libradius__L secure/lib/libssl__L: secure/lib/libcrypto__L
+secure/lib/libcrypto__L: lib/libthr__L
.if ${MK_LDNS} !=3D "no"
_lib_libldns=3D lib/libldns
-lib/libldns__L: secure/lib/libcrypto__L
+lib/libldns__L: secure/lib/libssl__L
.endif
.if ${MK_OPENSSH} !=3D "no"
_secure_lib_libssh=3D secure/lib/libssh
Index: lib/libldns/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- lib/libldns/Makefile (revision 339324)
+++ lib/libldns/Makefile (working copy)
@@ -19,7 +19,7 @@ SRCS=3D buffer.c dane.c dname.c dnssec.c dnssec_sign
=20
SRCS+=3D b64_ntop.c b64_pton.c
=20
-LIBADD=3D crypto
+LIBADD=3D ssl crypto
=20
WARNS ?=3D 3
=20
Index: share/mk/src.libnames.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- share/mk/src.libnames.mk (revision 339324)
+++ share/mk/src.libnames.mk (working copy)
@@ -273,7 +273,7 @@ _DP_mp=3D crypto
_DP_memstat=3D kvm
_DP_magic=3D z
_DP_mt=3D sbuf bsdxml
-_DP_ldns=3D crypto
+_DP_ldns=3D ssl crypto
.if ${MK_OPENSSL} !=3D "no"
_DP_fetch=3D ssl crypto
.else
--------------879ECB888FA72F86F1E30151--
--hKO69GqRcyIRY37dGKv62DFssCycezqA6--
--G32THXLYXbnk41VhPG9XiagD6sh5IvCrk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlvANLgACgkQfJ+WJvzb
8Uaq2gf7BP/RtrAMeHYUGpGINrGfvcSoabpyhTxUvbZz4v4Tc6Z7XjDjTJk5Zh1h
z7fLRZmOa3NeI5v698ENN6m5dxUx7GW2GMJlgQij3bzCqpYTwmf7sU5Lsqq1pXg9
SXDeXrMzVZ8IeWOGBxcvRAaMnj1v1h+i20RhVbUZFg9hGQ1lnrYh97ZOILn7rId2
6WzUNXItsqyI6Mgd+npcK9s0QG/4LpSDPG5gU0NFQKUU80KQYwE2WGDshIuzz3kx
1TR5B9ynlJj6088NFduwbmTOPyMrB/+5B8gie6HcO16TY14T+vIpexiecmeiEjZP
3P8kphP1L+GAKbbBxrCE91iO4d2BhQ==
=WTqA
-----END PGP SIGNATURE-----
--G32THXLYXbnk41VhPG9XiagD6sh5IvCrk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?07925544-3158-0812-56b4-6d4346dd8c1f>