Date: Thu, 28 Jul 2022 16:42:45 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 78ee8d1c4cda - main - qat: Import a new Intel (R) QAT driver Message-ID: <YuKSVdKLsHfc6PqW@kib.kiev.ua> In-Reply-To: <YuKRKxDnnP2lgvij@nuc> References: <202207271514.26RFE53M032558@gitrepo.freebsd.org> <YuI6kD0rmrl/dWX0@kib.kiev.ua> <YuKRKxDnnP2lgvij@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 28, 2022 at 09:37:47AM -0400, Mark Johnston wrote: > On Thu, Jul 28, 2022 at 10:28:16AM +0300, Konstantin Belousov wrote: > > On Wed, Jul 27, 2022 at 03:14:05PM +0000, Mark Johnston wrote: > > > The branch main has been updated by markj: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > > > > > commit 78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > > Author: Julian Grajkowski <julianx.grajkowski@intel.com> > > > AuthorDate: 2022-07-19 08:15:34 +0000 > > > Commit: Mark Johnston <markj@FreeBSD.org> > > > CommitDate: 2022-07-27 15:12:35 +0000 > > > > > > qat: Import a new Intel (R) QAT driver > > > > > > QAT in-tree driver ported from out-of-tree release available > > > from 01.org. > > > > > > The driver exposes complete cryptography and data compression > > > API in the kernel and integrates with Open Crypto Framework. > > > Details of supported operations, devices and usage can be found > > > in man and on 01.org. > > > > > > Patch co-authored by: Krzysztof Zdziarski <krzysztofx.zdziarski@intel.com> > > > Patch co-authored by: Michal Jaraczewski <michalx.jaraczewski@intel.com> > > > Patch co-authored by: Michal Gulbicki <michalx.gulbicki@intel.com> > > > Patch co-authored by: Julian Grajkowski <julianx.grajkowski@intel.com> > > > Patch co-authored by: Piotr Kasierski <piotrx.kasierski@intel.com> > > > Patch co-authored by: Adam Czupryna <adamx.czupryna@intel.com> > > > Patch co-authored by: Konrad Zelazny <konradx.zelazny@intel.com> > > > Patch co-authored by: Katarzyna Rucinska <katarzynax.kargol@intel.com> > > > Patch co-authored by: Lukasz Kolodzinski <lukaszx.kolodzinski@intel.com> > > > Patch co-authored by: Zbigniew Jedlinski <zbigniewx.jedlinski@intel.com> > > > > > > Reviewed by: markj, jhb (OCF integration) > > > Reviewed by: debdrup, pauamma (docs) > > > Sponsored by: Intel Corporation > > > Differential Revision: https://reviews.freebsd.org/D34632 > > > > I believe that qat_c2xxx lacks required > > MODULE_DEPEND(qat_c2xxx, firmware, ...) > > dependency line. > > I think you are right. It was missing before though, how did you > notice? I tried to load the qat_c2xxx module on the custom kernel config, where firmware is not included, because it is available as module. > > > I am not sure about qat since it depends on linuxkpi, but perhaps there > > something similar is needed as well. > > Seems so, the new qat uses native firmware(9) interfaces.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YuKSVdKLsHfc6PqW>