Date: Wed, 08 Oct 2008 11:15:52 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: umass quirk review ? Message-ID: <20081008111552.69843ndq7vkp4hgk@webmail.leidinger.net> In-Reply-To: <56363.1223454787@critter.freebsd.dk> References: <56363.1223454787@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Poul-Henning Kamp <phk@phk.freebsd.dk> (from Wed, 08 Oct 2008
08:33:07 +0000):
>
> I'm vaguely aware that we have some admin process in place for reviewing
> quirkentries in umass, but I seem unable to find out who to send my
> patch to ?
AFAIR the process is to register a PR so that we have a trace. The PR
should give infos about the device and the problems without the
quirks, and ideally why each quirk is needed for this device ("quirk A
solves error X and quirk B solves error Y" or something like this).
After that feel free to commit and close the PR.
Bye,
Alexander.
> Unless anybody objects, this goes in soonish.
>
> And yes, an infrared camera is a neat toy:
>
> http://phk.freebsd.dk/misc/misling.png
>
> Poul-Henning
>
>
> Index: usbdevs
> ===================================================================
> --- usbdevs (revision 183674)
> +++ usbdevs (working copy)
> @@ -1855,6 +1855,7 @@
> product OMNIVISION OV511PLUS 0xa511 OV511+ Camera
>
> /* OnSpec Electronic, Inc. */
> +product ONSPEC SDS_HOTFIND_D 0x0400 SDS-infrared.com Hotfind-D
> Infrared Camera
> product ONSPEC MDCFE_B_CF_READER 0xa000 MDCFE-B USB CF Reader
> product ONSPEC CFMS_RW 0xa001 SIIG/Datafab Memory Stick+CF Reader/Writer
> product ONSPEC READER 0xa003 Datafab-based Reader
> Index: umass.c
> ===================================================================
> --- umass.c (revision 183674)
> +++ umass.c (working copy)
> @@ -610,6 +610,10 @@
> UMASS_PROTO_SCSI,
> NO_QUIRKS
> },
> + { USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD,
> + UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
> + NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE
> + },
> { USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_MDCFE_B_CF_READER, RID_WILDCARD,
> UMASS_PROTO_SCSI,
> NO_QUIRKS
> --
> Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG | TCP/IP since RFC 956
> FreeBSD committer | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>
>
--
I'm definitely not in Omaha!
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081008111552.69843ndq7vkp4hgk>