Date: Tue, 21 Dec 2010 21:12:18 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r216623 - head/sys/dev/mii Message-ID: <201012212112.oBLLCIBA075588@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marius Date: Tue Dec 21 21:12:18 2010 New Revision: 216623 URL: http://svn.freebsd.org/changeset/base/216623 Log: - Add a comment regarding the fact that as documented in the datasheet manual 1000BASE-T modes of DP83865 only work together with other National Semiconductor PHYs. - Spell 10BASE-T correctly - Remove some redundant braces. Modified: head/sys/dev/mii/nsgphy.c Modified: head/sys/dev/mii/nsgphy.c ============================================================================== --- head/sys/dev/mii/nsgphy.c Tue Dec 21 20:47:06 2010 (r216622) +++ head/sys/dev/mii/nsgphy.c Tue Dec 21 21:12:18 2010 (r216623) @@ -140,11 +140,15 @@ nsgphy_attach(device_t dev) mii_phy_reset(sc); /* - * NB: the PHY has the 10baseT BMSR bits hard-wired to 0, - * even though it supports 10baseT. + * NB: the PHY has the 10BASE-T BMSR bits hard-wired to 0, + * even though it supports 10BASE-T. */ sc->mii_capabilities = (PHY_READ(sc, MII_BMSR) | - (BMSR_10TFDX | BMSR_10THDX)) & ma->mii_capmask; + BMSR_10TFDX | BMSR_10THDX) & ma->mii_capmask; + /* + * Note that as documented manual 1000BASE-T modes of DP83865 only + * work together with other National Semiconductor PHYs. + */ if (sc->mii_capabilities & BMSR_EXTSTAT) sc->mii_extcapabilities = PHY_READ(sc, MII_EXTSR);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012212112.oBLLCIBA075588>