Date: Wed, 12 Aug 2009 09:24:48 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Ed Schouten <ed@80386.nl>, Kip Macy <kmacy@freebsd.org>, Robert Noland <rnoland@freebsd.org>, "Arno J. Klaassen" <arno@heho.snv.jussieu.fr>, Julian Elischer <julian@elischer.org>, FreeBSD Current <current@freebsd.org> Subject: Re: 8.0-BETA2: mi_startup() panic on VIA C7 diskless Message-ID: <200908120924.49300.jhb@freebsd.org> In-Reply-To: <4A81EEE8.5060405@elischer.org> References: <wp8whraago.fsf@heho.snv.jussieu.fr> <20090811195240.GI1292@hoeg.nl> <4A81EEE8.5060405@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 11 August 2009 6:21:28 pm Julian Elischer wrote: > Ed Schouten wrote: > > * Kip Macy <kmacy@freebsd.org> wrote: > >> http://people.freebsd.org/~kmacy/flowtable_boot.patch > > > > + if ((V_flowtable_enable == 0) || (V_flowtable_ready == 0) > > > > should probably read: > > > > + if (V_flowtable_enable == 0 || V_flowtable_ready == 0) > > > > Right? > > > > > I prefer the first, with an extra closing paren. style(9) prefers the latter assuming that it isn't confusing to read the latter (I do not think it is). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908120924.49300.jhb>