Date: Wed, 13 Dec 2017 06:54:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: rgrimes@freebsd.org Cc: Warner Losh <imp@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r326809 - head/sys/dev/cardbus Message-ID: <20171213065443.GA31341@FreeBSD.org> In-Reply-To: <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net> References: <201712122022.vBCKM9Kd050769@repo.freebsd.org> <201712122039.vBCKdcV8088346@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 12, 2017 at 12:39:38PM -0800, Rodney W. Grimes wrote: > > New Revision: 326809 > > URL: https://svnweb.freebsd.org/changeset/base/326809 > > > > Log: > > 1k objects on the stack are a bad idea. While it's likely safe in this > > context, it's also safe to allocate the memory and free it instead. > > > > Noticed by: Eugene Grosbein's script > > YEA!!! One down, 20 to go and then see how the kstack issue does? > > And thank you for quickly fixing this. It's very promising to see debloat-type of work having started. On the related note, what is current consensus with r326758, is it going to be backed out and stack issues investigated and fixed? I am worried since kib@ had mentioned that he's "almost sure that [32-bit x86 workstation] users would get troubles now" [*] and I'm one of them. ./danfe [*] https://lists.freebsd.org/pipermail/svn-src-head/2017-December/107237.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171213065443.GA31341>