Date: Sun, 10 Oct 2004 13:31:57 +0400 From: Gleb Smirnoff <glebius@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf2.c src/share/man/man9 mbuf_tags.9 Message-ID: <20041010093157.GA11523@cell.sick.ru> In-Reply-To: <41686584.6070606@errno.com> References: <200410091325.i99DPK00097724@repoman.freebsd.org> <4168009A.303@errno.com> <20041009213710.GB8922@cell.sick.ru> <41686584.6070606@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam, The change is reverted. On Sat, Oct 09, 2004 at 03:26:12PM -0700, Sam Leffler wrote: S> 1. You changed this without discussion. S> 2. It breaks the intentional purpose of subclassing the m_tag_free method. S> 3. Openbsd compatibility is not broken by calling through the method S> pointer; in fact calling through the method pointer is required to S> maintain compatbility (think about it). It is broken since in OpenBSD and FreeBSD function with same name do different things. S> You did not find existing uses of subclassing because I backed out the S> vlan changes to use a private pool for unrelated reasons. I very very S> strongly disagree with this change and want it reverted. This was not broken. Look in my changes to uipc_mbuf2.c, you'll see that m_tag_delete() was changed so that it calls free thru method pointer. As I said, I've checked all m_tag_free() consumers, and nothing is affected. My main purpose for this change was to create a possibility to create a custom free method, which inherits default method. How it is possible to do it now, without API change? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041010093157.GA11523>