Date: Thu, 8 Mar 2012 09:51:02 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Mitsuru IWASAKI <iwasaki@jp.freebsd.org> Cc: freebsd-current@freebsd.org, freebsd-wireless@freebsd.org, bschmidt@freebsd.org Subject: Re: patches for if_iwi and wlan for WEP mode Message-ID: <CAJ-Vmo=hnWXoU4grPAf3%2BGea2RA%2Bn%2BtzKFrQgwnckKm9vzLxHg@mail.gmail.com> In-Reply-To: <20120309.023227.95065896.iwasaki@jp.FreeBSD.org> References: <201203062005.15276.bschmidt@freebsd.org> <20120308.003844.08316346.iwasaki@jp.FreeBSD.org> <CAJ-VmomDUF2ydBfjzYaxPimZUtdCbbg2ScUz5KCw3ze3XtTmiw@mail.gmail.com> <20120309.023227.95065896.iwasaki@jp.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8 March 2012 09:32, Mitsuru IWASAKI <iwasaki@jp.freebsd.org> wrote: > Hi, > >> I'd rather you didn't commit iwi_update_mcast() unless you absolutely >> know that the NIC doesn't need to be notified of multicast group >> membership changes. If so, please commit that as a separate fix. > > OK, I'd do so. =A0I don't need mcast stuff for the time being, > instead I'd check other area such as suspend/resume for the next target. > > Today's one at: > http://people.freebsd.org/~iwasaki/iwi/iwi-20120308.diff > > # 2 lines fix, after all ;) :-) Thanks for this! Once it's done, let's sort out the multicast stuff. Either we set IFF_ALLMULTI as AK suggested or we figure out and write a proper _update_mcast() function. We can commit that as a separate patch. I found my 2945 NIC btw, so hopefully I can get some test in on saturday. Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=hnWXoU4grPAf3%2BGea2RA%2Bn%2BtzKFrQgwnckKm9vzLxHg>