Date: Mon, 17 Jun 2019 08:51:16 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Niclas Zeising <zeising@freebsd.org> Cc: rgrimes@freebsd.org, Benjamin Kaduk <bjkfbsd@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r349133 - head/share/man/man4 Message-ID: <201906171551.x5HFpGbI009679@gndrsh.dnsmgr.net> In-Reply-To: <f1f79f31-c2fb-2d54-2bd9-7cea1f995f06@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 2019-06-17 12:27, Niclas Zeising wrote: > > On 2019-06-17 11:03, Rodney W. Grimes wrote: > >>> On 2019-06-17 09:56, Benjamin Kaduk wrote: > >>>> On Sun, Jun 16, 2019 at 10:42 PM Niclas Zeising <zeising@freebsd.org > >>>> <mailto:zeising@freebsd.org>> wrote: > >>>> > >>>> ???? Author: zeising (doc,ports committer) > >>>> ???? Date: Mon Jun 17 05:41:47 2019 > >>>> ???? New Revision: 349133 > >>>> ???? URL: https://svnweb.freebsd.org/changeset/base/349133 > >>>> > >>>> ???? Log: > >>>> ????? ? pci(4): Document PCIOCATTACHED > >>>> > >>>> ????? ? Document the PCIOCATTACHED ioctl(2) in the pci(4) manual. > >>>> ????? ? PCIOCATTACHED is used to query if a driver has attached to a > >>>> PCI. > >>>> > >>>> ????? ? Reviewed by:? bcr, imp > >>>> ????? ? MFC after:? ? 2 weeks > >>>> ????? ? Differential Revision: https://reviews.freebsd.org/D20652 > >>>> > >>>> ???? Modified: > >>>> ????? ? head/share/man/man4/pci.4 > >>>> > >>>> ???? Modified: head/share/man/man4/pci.4 > >>>> > >>>> ============================================================================== > >>>> > >>>> ???? --- head/share/man/man4/pci.4? ?Mon Jun 17 03:48:44 2019 > >>>> ???? (r349132) > >>>> ???? +++ head/share/man/man4/pci.4? ?Mon Jun 17 05:41:47 2019 > >>>> ???? (r349133) > >>>> ???? @@ -24,7 +24,7 @@ > >>>> ????? ?.\" > >>>> ????? ?.\" $FreeBSD$ > >>>> ????? ?.\" > >>>> ???? -.Dd June 14, 2018 > >>>> ???? +.Dd June 17, 2019 > >>>> ????? ?.Dt PCI 4 > >>>> ????? ?.Os > >>>> ????? ?.Sh NAME > >>>> ???? @@ -333,6 +333,26 @@ The limitations on data width described for > >>>> ????? ?reading registers, above, also apply to writing > >>>> ????? ?.Tn PCI > >>>> ????? ?configuration registers. > >>>> ???? +.It PCIOCATTACHED > >>>> ???? +This > >>>> ???? +.Xr ioctl 2 > >>>> ???? +allows users to query if a driver is attached to the > >>>> ???? +.Tn PCI > >>>> ???? +specified in the passed-in > >>>> > >>>> > >>>> Is there a missing word like "device" here? > >> > >> Actally I think the missing word, in both cases, is register, > >> unless I am misreading some part of the manual page and > >> what a struct pci_io points at.? I guess if the pi_reg is null > >> then this would be device.? Either way there is defanity a > >> missing word. > > > > I'll try to fix this.? In the PCIOCWRITE case, perhaps register is best, > > however, inthe PCIOCATTACHED case, device is best, I think. > > I'll create a patch and put it for review, I'll get back to you once > > it's done. > > Regards > > > > Here's the review with my proposed change. Let me know what you think. > https://reviews.freebsd.org/D20671 This looks good to me, cant login right now to hit accept, but consider the rewview accepted by me too. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906171551.x5HFpGbI009679>