Date: Thu, 23 Apr 1998 13:05:50 +0200 From: Eivind Eklund <eivind@yes.no> To: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys time.h Message-ID: <19980423130550.30970@follo.net> In-Reply-To: <199804230336.NAA30536@godzilla.zeta.org.au>; from Bruce Evans on Thu, Apr 23, 1998 at 01:36:19PM %2B1000 References: <199804230336.NAA30536@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote:
> >eivind 1998/04/22 17:11:32 PDT
> >
> > Modified files:
> > sys/sys time.h
> > Log:
> > Wrap timerclear in do { ... } while(0)
>
> Wrong fix. The do-while(0) hack is bogus for macros that expand to an
> expression.
I strongly disagree. Such macros should most definately have
do { ... } while(0) protection, to avoid people depending on the fact
that they just happen to be expressions. Otherwise, we're inviting
people to depend on implementation details.
Eivind.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980423130550.30970>