Date: Mon, 07 Oct 2002 15:41:05 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/btx/btxldr btxldr.s Message-ID: <XFMail.20021007154105.jhb@FreeBSD.org> In-Reply-To: <22628.1034018839@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07-Oct-2002 Poul-Henning Kamp wrote: > In message <XFMail.20021007152306.jhb@FreeBSD.org>, John Baldwin writes: >> >>On 07-Oct-2002 Poul-Henning Kamp wrote: >>> phk 2002/10/07 12:12:36 PDT >>> >>> Modified files: >>> sys/boot/i386/btx/btxldr btxldr.s >>> Log: >>> Correctly adjust for moved start address. >>> >>> It seems that the existence of a "depend" target in src/sys/boot is not >>> to be taken as an indication that it actually does what one would expect, >>> at least it clearly threw my testing off. >> >>Well, the problem is that the boot code has a lot of indirect magic numbers >>in it and there aren't any real headers that are shared for these various >>things to depend on. This stuff is kind of gross. :) > > I was surprised to see that absolutely no common headers were used, > is there a technical reason for that ? Probably not. Well, the asm code is mostly written with # comments which would all have to be redone if we went with using cpp with these files. We could maybe hack something with m4 at some point. I think I would prefer just biting the bullet and going with cpp at some point. > Otherwise it would be a nice improvement for the future. Agreed. > The good news in all of this is that it will move the 8k barrier > up to 64k so a lot of this code can be written less convoluted once > we get there. We might want to change boot2 to zero it's own bss at some point just to make it happy if possible. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021007154105.jhb>