Date: Fri, 7 May 1999 15:49:21 +0930 From: Greg Lehey <grog@lemis.com> To: Bruce Evans <bde@zeta.org.au>, Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys disk.h Message-ID: <19990507154920.L40359@freebie.lemis.com> In-Reply-To: <199905070559.PAA12395@godzilla.zeta.org.au>; from Bruce Evans on Fri, May 07, 1999 at 03:59:09PM %2B1000 References: <199905070611.QAA13928@godzilla.zeta.org.au> <199905070559.PAA12395@godzilla.zeta.org.au> <7862.926057236@critter.freebsd.dk> <199905070559.PAA12395@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, 7 May 1999 at 16:11:56 +1000, Bruce Evans wrote: >>> sys/disk.h was intentionally not removed, since it has some historical >>> interest and probably should eventually contain half of the declarations >>> that are now in sys/disklabel.h. You just weren't supposed to use it. >> >> Best way to make sure people don't is to remove it. > > #error "you are not meant to use this" Funny, I thought the documentation went into /usr/src/share/doc, and old, no longer used files went to Attic. What am I missing? People with any kind of memory will recall that I don't always agree with phk, but I think he's 100% right here (and in some other tidying up stuff he's doing). There's a place for historical files, but it's not today's -CURRENT source tree. The only thing that will happen if the cruft is left in -CURRENT is that people like me will use the stuff. An #error in the file would just confuse the issue. As phk has pointed out, struct buf contains a whole lot of fields which never got used, but which countless generations of driver programmers religiously initialized. Cleaning this stuff up is good. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990507154920.L40359>