Date: Thu, 23 Apr 1998 08:36:32 -0400 (EDT) From: Peter Dufault <dufault@hda.com> To: eivind@yes.no (Eivind Eklund) Cc: cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys time.h Message-ID: <199804231236.IAA23320@hda.hda.com> In-Reply-To: <19980423130550.30970@follo.net> from Eivind Eklund at "Apr 23, 98 01:05:50 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote:
> > >eivind 1998/04/22 17:11:32 PDT
> > >
> > > Modified files:
> > > sys/sys time.h
> > > Log:
> > > Wrap timerclear in do { ... } while(0)
> >
> > Wrong fix. The do-while(0) hack is bogus for macros that expand to an
> > expression.
>
> I strongly disagree. Such macros should most definately have
> do { ... } while(0) protection, to avoid people depending on the fact
> that they just happen to be expressions. Otherwise, we're inviting
> people to depend on implementation details.
Given no specification for timerclear pre-existing behavior
should be maintained. Given a specification that says it behaves
as if it returns void you're right.
Peter
--
Peter Dufault (dufault@hda.com) Realtime development, Machine control,
HD Associates, Inc. Safety critical systems, Agency approval
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804231236.IAA23320>