Date: Wed, 21 Feb 2001 14:24:36 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Peter Pentchev <roam@orbitel.bg> Cc: Ben Smithurst <ben@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <3A93B384.D51AB1AA@FreeBSD.org> References: <200102211210.f1LCAKN41997@freefall.freebsd.org> <20010221141342.A98551@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Pentchev wrote: > On Wed, Feb 21, 2001 at 04:10:19AM -0800, Ben Smithurst wrote: > > ben 2001/02/21 04:10:19 PST > > > > Modified files: > > share/man/man9 style.9 > > Log: > > Don't suggest > > > > if (error = function(a1, a2)) > > > > since it causes a warning with -Wall. Change it so it has an explicit test > > against zero, > > > > if ((error = function(a1, a2)) != 0) > > I've sometimes seen tests like: > > if (error = function(a1, a2), error != 0) > > Is this not a bit clearer? I don't think so. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A93B384.D51AB1AA>