Date: Thu, 23 Apr 1998 14:47:43 +0200 From: Eivind Eklund <eivind@yes.no> To: Peter Dufault <dufault@hda.com> Cc: cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/sys time.h Message-ID: <19980423144743.33016@follo.net> In-Reply-To: <199804231236.IAA23320@hda.hda.com>; from Peter Dufault on Thu, Apr 23, 1998 at 08:36:32AM -0400 References: <19980423130550.30970@follo.net> <199804231236.IAA23320@hda.hda.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 23, 1998 at 08:36:32AM -0400, Peter Dufault wrote:
> > On Thu, Apr 23, 1998 at 01:36:19PM +1000, Bruce Evans wrote:
> > > >eivind 1998/04/22 17:11:32 PDT
> > > >
> > > > Modified files:
> > > > sys/sys time.h
> > > > Log:
> > > > Wrap timerclear in do { ... } while(0)
> > >
> > > Wrong fix. The do-while(0) hack is bogus for macros that expand to an
> > > expression.
> >
> > I strongly disagree. Such macros should most definately have
> > do { ... } while(0) protection, to avoid people depending on the fact
> > that they just happen to be expressions. Otherwise, we're inviting
> > people to depend on implementation details.
>
> Given no specification for timerclear pre-existing behavior
> should be maintained.
Pre-existing behaviour was added two weeks ago, and was wrong at that
point (a non-parenthesized expression). I did the change the day
after the original code was committed, but had it in my tree for a
while before committing it.
> Given a specification that says it behaves as if it returns void
> you're right.
AFAIK, the only specification for timerclear() is the code. The code
says it returns void. Happy? ;-)
Eivind.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980423144743.33016>