Date: Fri, 9 Mar 2007 21:04:50 +0000 (UTC) From: Julian Elischer <julian@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200703092104.l29L4ogw046069@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
julian 2007-03-09 21:04:50 UTC
FreeBSD src repository
Modified files:
sys/netgraph ng_base.c
Log:
ng_apply_item should be void. It is called from the interrupt source or
from whoever has dequeued the item from the queue. Generally they have
no interest in the result, and even if it is called by the queuer, it
should still pretend that it was queued. The queuer should be assuming
that the call was queued and giving them the false confidence that they
are getting status leads to hard to find bugs.
Make it a void and remove all the code that tried to return status through it.
Revision Changes Path
1.127 +85 -14 src/sys/netgraph/ng_base.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200703092104.l29L4ogw046069>