Date: Wed, 20 Apr 2005 17:37:27 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.ORG> To: Garrett Wollman <wollman@csail.mit.edu> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h Message-ID: <yge1x95onco.wl%ume@mahoroba.org> In-Reply-To: <16997.30227.769989.36407@khavrinen.csail.mit.edu> References: <ygeu0m2zim9.wl%ume@mahoroba.org> <Pine.GSO.4.43.0504191516330.6115-100000@sea.ntplx.net> <ygesm1mzhol.wl%ume@mahoroba.org> <16997.30227.769989.36407@khavrinen.csail.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Tue, 19 Apr 2005 17:20:19 -0400
>>>>> Garrett Wollman <wollman@csail.mit.edu> said:
wollman> If they are generally useful they should be globally visible, with the
wollman> standard FreeBSD namespace protections. (In this case, this probably
wollman> means that the __ versions stay as they are, and non-__ versions can
wollman> be defined using aliases in a separate compilation unit.)
I'm not sure they are really useful. I think they are preffered to
use for thread applications. However, our get{serv,proto}*() is now
thread-safe. So, we don't need to use get{serv,proto}*_r() to have
just thread-safeness.
Indeed, I started this work to call getservby*_r() from getaddrinfo()
and getnameinfo(). But, after all, I didn't modify getaddrinfo() and
getnameinfo() to call getservby*_r() directly.
Further, getserv*_r() takes struct servent_data for its argument. So,
once we decide to expose them, we will need to pay attention to an ABI
compatibility in the future. So, we should be careful, IMHO.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yge1x95onco.wl%ume>