Date: Sat, 17 Oct 2015 13:11:47 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Garrett Cooper <ngie@FreeBSD.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, jenkins-admin@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: FreeBSD_HEAD_amd64_gcc4.9 - Build #673 - Failure Message-ID: <F3DFF8C1-4D8D-4A29-B102-CA6A19B131E2@FreeBSD.org> In-Reply-To: <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com> References: <1743862498.27.1445058611319.JavaMail.jenkins@jenkins-9.freebsd.org> <5621D9F1.9080707@FreeBSD.org> <5621DDB1.8020807@FreeBSD.org> <31F4FEC4-B677-4EA1-BD67-F2DC458A99E4@gmail.com> <2B9A4B89-6D0D-4549-B249-FB30A8117DDF@gmail.com> <78883694-7B54-4AC3-9B5B-D715D5DA1F88@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
On 17 Oct 2015, at 09:09, NGie Cooper <yaneurabeya@gmail.com> wrote:
...
> Also, this logic looks troublesome:
>=20
> 42 .if empty(TOOLSDIR) || !exists(${TOOLSDIR}/usr/bin/clang-tblgen)
> 43 .if ${MACHINE} =3D=3D "host" && defined(BOOTSTRAPPING_TOOLS)
> 44 .if !empty(LEGACY_TOOLS) && exists(${LEGACY_TOOLS}/usr/bin/tblgen)
> 45 TOOLSDIR=3D ${LEGACY_TOOLS}
> 46 .endif
> 47 .endif
> 48 .if ${MK_STAGING} =3D=3D "yes" && =
exists(${STAGE_HOST_OBJTOP:Uno}/usr/bin/tblgen)
> 49 TOOLSDIR=3D ${STAGE_HOST_OBJTOP}
> 50 .endif
> 51 .if exists(${LEGACY_TOOLS:Uno}/usr/bin/tblgen)
> 52 TOOLSDIR=3D ${LEGACY_TOOLS}
> 53 .endif
> 54 .endif
> 55 TOOLSDIR?=3D
> 56 .if !empty(TOOLSDIR) && exists(${TOOLSDIR}/usr/bin/clang-tblgen)
> 57 TBLGEN=3D ${TOOLSDIR}/usr/bin/tblgen
> 58 CLANG_TBLGEN=3D ${TOOLSDIR}/usr/bin/clang-tblgen
> 59 .endif
> 60 TBLGEN?=3D tblgen
> 61 CLANG_TBLGEN?=3D clang-tblgen
>=20
> This kind of complexity matched something that I simplified at $work =
due to build races=85
This stuff was added by sjg as part of his meta-mode commit frenzy in
r284345, but I never really agreed to it, nor do I understand what its
function is. It was just splattered all over the tree.
Can we just remove it for now, and put it back when it works, and is
actually used for something? :-)
-Dimitry
--Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.28
iEYEARECAAYFAlYiLPkACgkQsF6jCi4glqO8IQCeKYF7C2qo0ZZN7EWFlHGIk6oT
xv0An1PySRgkaiArhsDQHb23yaWMgZ9d
=0VX/
-----END PGP SIGNATURE-----
--Apple-Mail=_03F19085-9B0A-4EBD-A7F1-2FE1A1C268A6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F3DFF8C1-4D8D-4A29-B102-CA6A19B131E2>