Date: Mon, 28 Apr 2025 11:17:45 -0500 From: Jose Luis Duran <jlduran+freebsd@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, Shawn Webb <shawn.webb@hardenedbsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a098111a28ed - main - secure: Add ssh-sk-client to all consumers of libssh Message-ID: <CAPwQLceZMz%2BMw1Bt63va%2BvND77KGnwBjBz8WkFDZGN%2BCtq96iA@mail.gmail.com> In-Reply-To: <5a261558-6c1f-4e29-a71b-fd3cb6bd1e70@FreeBSD.org> References: <202504220207.53M27okn077850@gitrepo.freebsd.org> <kwr5lq63fzct3dkyi5c3x6s7v5mdu3e47tfci7c43fw27fvljv@x4p5zr6s4auf> <A78D317E-914E-4F6B-AFA4-438D4B50FEA8@freebsd.org> <5a261558-6c1f-4e29-a71b-fd3cb6bd1e70@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 28, 2025 at 10:45=E2=80=AFAM John Baldwin <jhb@freebsd.org> wro= te: > > On 4/24/25 18:56, Jessica Clarke wrote: > > On 24 Apr 2025, at 23:45, Shawn Webb <shawn.webb@hardenedbsd.org> wrote= : > >> On Tue, Apr 22, 2025 at 02:07:50AM +0000, John Baldwin wrote: > >>> The branch main has been updated by jhb: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da098111a28ed59e1ab1101= ad09913f0235ebd28f > >>> > >>> commit a098111a28ed59e1ab1101ad09913f0235ebd28f > >>> Author: John Baldwin <jhb@FreeBSD.org> > >>> AuthorDate: 2025-04-22 02:05:28 +0000 > >>> Commit: John Baldwin <jhb@FreeBSD.org> > >>> CommitDate: 2025-04-22 02:05:28 +0000 > >>> > >>> secure: Add ssh-sk-client to all consumers of libssh > >>> > >>> These all failed to link with ld.bfd used by GCC due to > >>> Fssh_sshsk_sign being an unresolved symbol. > >>> > >>> Fixes: 65d8491719bb ("secure: Adapt Makefile to ssh-sk-c= lient everywhere") > >> > >> Hey John, > >> > >> I'm getting the following error from the RTLD when the rc scripts > >> start sshd: > >> > >> =3D=3D=3D=3D BEGIN LOG =3D=3D=3D=3D > >> ld-elf.so.1: /usr/lib/libprivatessh.so.5: Undefined symbol "Fssh_sshsk= _sign > >> =3D=3D=3D=3D END LOG =3D=3D=3D=3D > >> > >> This is on HardenedBSD 15-CURRENT/amd64. I'll try to reproduce next > >> week with vanilla FreeBSD, unless someone else beats me to it. > > This error seems to be that you've built the new libssh but have an old > sshd, etc. > > > I don=E2=80=99t understand how this is meant to work. sshsk_sign is use= d by > > sshkey.c, which is in libssh, so why are we putting the definition of > > sshsk_sign (namespaced) in each and every program? > > Yeah, it's not clear to me that the original commit is correct. It makes > libssh no longer be self-contained. I have created: https://reviews.freebsd.org/D50020 > -- > John Baldwin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPwQLceZMz%2BMw1Bt63va%2BvND77KGnwBjBz8WkFDZGN%2BCtq96iA>