Date: Thu, 25 Oct 2007 15:49:10 -0400 (EDT) From: Daniel Eischen <deischen@freebsd.org> To: Andrey Chernov <ache@nagual.pp.ru> Cc: cvs-src@freebsd.org, Scott Long <scottl@samsco.org>, src-committers@freebsd.org, d@delphij.net, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c Message-ID: <Pine.GSO.4.64.0710251547500.29092@sea.ntplx.net> In-Reply-To: <20071025192618.GH16187@nagual.pp.ru> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> <Pine.GSO.4.64.0710251516220.29092@sea.ntplx.net> <4720EC70.8@delphij.net> <20071025192618.GH16187@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Oct 2007, Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 12:20:16PM -0700, LI Xin wrote: >> Daniel Eischen wrote: >>> Why not simply avoid the error check for inlines. Solaris >>> doesn't seem to add a check, it just does the conversion. >>> The non-inlined versions do error checking. >> >> I'll take a look at this and provide a patch for review. > > I don't think it is a good idea. Even lots current-on-current > programs becomes broken. Ok, just making a suggestion. I don't feel too strongly one way or the other. -- DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0710251547500.29092>