Date: Fri, 30 Jun 2006 20:52:46 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_atmsubr.c if_stf.c if_tun.c src/sys/netinet if_ether.c ip_divert.c ip_fw2.c src/sys/netinet6 in6.c in6_var.h src/sys/nfsclient bootp_subr.c nfs_diskless.c Message-ID: <20060630165246.GA81169@comp.chem.msu.su> In-Reply-To: <20060630114410.GZ1383@FreeBSD.org> References: <200606291922.k5TJM5ev007314@repoman.freebsd.org> <20060630114410.GZ1383@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 30, 2006 at 03:44:10PM +0400, Gleb Smirnoff wrote: > On Thu, Jun 29, 2006 at 07:22:05PM +0000, Yar Tikhiy wrote: > Y> Modified files: > Y> sys/net if.c if_atmsubr.c if_stf.c if_tun.c > Y> sys/netinet if_ether.c ip_divert.c ip_fw2.c > Y> sys/netinet6 in6.c in6_var.h > Y> sys/nfsclient bootp_subr.c nfs_diskless.c > Y> Log: > Y> There is a consensus that ifaddr.ifa_addr should never be NULL, > Y> except in places dealing with ifaddr creation or destruction; and > Y> in such special places incomplete ifaddrs should never be linked > Y> to system-wide data structures. Therefore we can eliminate all the > Y> superfluous checks for "ifa->ifa_addr != NULL" and get ready > Y> to the system crashing honestly instead of masking possible bugs. > Y> > Y> Suggested by: glebius, jhb, ru > > I think this can also close few reports from Coverity. The only report I was aware of was CID 448. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060630165246.GA81169>