Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jun 2010 11:27:21 -0700
From:      Garrett Cooper <gcooper@FreeBSD.org>
To:        Andrius Morkunas <andrius@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 179675 for review
Message-ID:  <AANLkTilmvDwJlMfH6XwIMu0V4oS-RkotnDVpFLbLhnmp@mail.gmail.com>
In-Reply-To: <201006161148.o5GBmrDq093951@repoman.freebsd.org>
References:  <201006161148.o5GBmrDq093951@repoman.freebsd.org>

index | next in thread | previous in thread | raw e-mail

On Wed, Jun 16, 2010 at 4:48 AM, Andrius Morkunas <andrius@freebsd.org> wrote:
> http://p4web.freebsd.org/@@179675?ac=10
>
> Change 179675 by andrius@klevas on 2010/06/16 11:48:11
>
>        Add NO_USE_CC.
>
>        If defined, NO_USE_CC forces USE_CC and USE_GCC to be ignored.
>        Before, there was no way to NOT respect USE_CC/USE_GCC variables.
>
> Affected files ...
>
> .. //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk#2 edit
>
> Differences ...
>
> ==== //depot/projects/soc2010/clangports/ports/Mk/bsd.compiler.mk#2 (text+ko) ====
>
> @@ -3,6 +3,11 @@
>  # PORTS_CXX should only be set if PORTS_CC is neither gcc nor clang
>  PORTS_CXX?=    g++
>
> +.if defined(NO_USE_CC)
> +.undef USE_CC
> +.undef USE_GCC
> +.endif
> +
>  # Handle USE_CC
>  .if defined(USE_CC)
>  # Check if port requires specific compiler
> @@ -35,7 +40,6 @@
>
>  # Clang
>  .elif !empty(PORTS_CC:Mclang*)
> -# TODO: handle something like USE_CLANG here when/if there's need for that
>  CC=                    clang
>  CXX=           clang++
>  .else

Why not just check to see if CC is defined and empty?
-Garrett


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTilmvDwJlMfH6XwIMu0V4oS-RkotnDVpFLbLhnmp>