Date: Tue, 03 Dec 2013 00:16:28 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r258848 - user/hrs/releng/release Message-ID: <20131203.001628.1233827032249325723.hrs@allbsd.org> In-Reply-To: <20131202145103.GG1839@glenbarber.us> References: <201312021440.rB2EeQa6012210@svn.freebsd.org> <20131202145103.GG1839@glenbarber.us>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Glen Barber <gjb@FreeBSD.org> wrote in <20131202145103.GG1839@glenbarber.us>: gj> On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote: gj> > Author: hrs gj> > Date: Mon Dec 2 14:40:26 2013 gj> > New Revision: 258848 gj> > URL: http://svnweb.freebsd.org/changeset/base/258848 gj> > gj> > Log: gj> > Improve robustness and consistency, and remove redundant lines with no gj> > major functional change: gj> gj> > [...] gj> gj> > +if [ $($ID -u) -ne 0 ]; then gj> > + echo 1>&2 "$0: Needs to be run as root." gj> > + exit 1 gj> > +fi gj> > # The directory within which the release will be built. gj> > -CHROOTDIR="/scratch" gj> > +: ${CHROOTDIR:=/scratch} gj> > +: ${CHROOT_CMD:=chroot $CHROOTDIR} gj> > +: ${DESTDIR=:/R/} gj> > +: ${MAKEOBJDIRPREFIX:=/usr/obj} gj> > gj> gj> Please do not merge these changes to head/. It was intentional that gj> environment was not honored, as everything should be set in the gj> configuration file. gj> gj> It is possible to use the environment in the configuration file, such gj> as: gj> gj> ---- release.conf ---- gj> : ${_DESTDIR=:/R/} gj> DESTDIR=${_DESTDIR} gj> ---- release.conf ---- Everything can be overridden by a configuration file regardless of whether envvars are honored even after this change. What is the problem? I do not see negative effect assuming a conf file is used. -- Hiroki [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlKcpEwACgkQTyzT2CeTzy0ruACgmEOLB7bMMVYEQHPvQhCB7zhE sEIAoIN1orI+WPZzSq4DfhME6fREGQ0e =MTn+ -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131203.001628.1233827032249325723.hrs>