Date: Thu, 3 Jan 2008 06:15:53 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 132369 for review Message-ID: <200801030615.m036FrOH011207@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=132369 Change 132369 by imp@imp_paco-paco on 2008/01/03 06:15:10 I think I can just remove the reference to PG_BUSY here since it changed into VOP_BUSY, and also remove the page queue locking operations. I think they are also not needed. Affected files ... .. //depot/projects/mips2-jnpr/src/sys/mips/mips/pmap.c#7 edit Differences ... ==== //depot/projects/mips2-jnpr/src/sys/mips/mips/pmap.c#7 (text+ko) ==== @@ -875,7 +875,7 @@ } void -pmap_pinit0(struct pmap *pmap) +pmap_pinit0(pmap_t pmap) { int i; @@ -896,8 +896,8 @@ * Initialize a preallocated and zeroed pmap structure, * such as one in a vmspace structure. */ -void -pmap_pinit(struct pmap *pmap) +int +pmap_pinit(pmap_t pmap) { vm_page_t ptdpg; int i; @@ -917,11 +917,16 @@ */ ptdpg = vm_page_alloc( NULL, NUSERPGTBLS, req); +#if 0 + /* I think we can just delete these, now that PG_BUSY is gone */ vm_page_lock_queues(); vm_page_flag_clear(ptdpg, PG_BUSY); /* not usually mapped*/ +#endif ptdpg->valid = VM_PAGE_BITS_ALL; +#if 0 vm_page_unlock_queues(); +#endif pmap->pm_segtab = (pd_entry_t *) MIPS_PHYS_TO_CACHED(VM_PAGE_TO_PHYS(ptdpg)); @@ -936,6 +941,8 @@ } TAILQ_INIT(&pmap->pm_pvlist); bzero(&pmap->pm_stats, sizeof pmap->pm_stats); + + return (1); } /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801030615.m036FrOH011207>