Date: Thu, 25 Feb 2021 08:43:27 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253839] sys/buf.h uses bool type that can be undefined since commit 2bfd8992c7c7 Message-ID: <bug-253839-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253839 Bug ID: 253839 Summary: sys/buf.h uses bool type that can be undefined since commit 2bfd8992c7c7 Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: kib@FreeBSD.org Attachment #222811 maintainer-approval?(kib@FreeBSD.org) Flags: CC: kib@FreeBSD.org Created attachment 222811 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222811&action= =3Dedit Add include defining bool types. I was upgrading to recent head and I got this error when compiling port devel/libgtop in poudriere: In file included from procmap.c:54: In file included from /usr/include/ufs/ufs/inode.h:50: /usr/include/sys/buf.h:569:1: error: unknown type name 'bool' bool inmem(struct vnode *, daddr_t); ^ procmap.c:101:25: warning: unused variable 'um' [-Wunused-variable] struct ufsmount um; ^ procmap.c:405:16: warning: cast from 'gchar *' (aka 'char *') to 'glibtop_map_entry *' (aka 'struct _glibtop_map_entry *') increases required alignment from 1 to 8 [-Wcast-align] return (glibtop_map_entry*) g_array_free(maps, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 1 error generated. gmake[4]: *** [Makefile:573: procmap.lo] Error 1 gmake[4]: *** Waiting for unfinished jobs.... Looking at sources I noticed commit 2bfd8992c7c7 adding that bool type to sys/buf.h I'm not sure what the correct cure is. I noticed other system sources inclu= ding buf.h generally include sys/types.h that defines bool types for c. I think buf.h should include that one directly since it uses a type defined there. I'm attaching a patch to this effect. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253839-227>