Date: Thu, 25 Oct 2001 07:10:02 -0700 (PDT) From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/31483: minor correction in error message printed by acpiconf.8 Message-ID: <200110251410.f9PEA2c29233@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/31483; it has been noted by GNATS. From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: cjclark@alum.mit.edu, cristjc@earthlink.net Cc: roam@ringlet.net, freebsd-gnats-submit@FreeBSD.ORG, msmith@FreeBSD.ORG, iwasaki@FreeBSD.ORG, iwasaki@jp.FreeBSD.org Subject: Re: bin/31483: minor correction in error message printed by acpiconf.8 Date: Thu, 25 Oct 2001 23:06:15 +0900 (JST) Hi, > > On Thu, Oct 25, 2001 at 03:17:55AM +0300, Giorgos Keramidas wrote: > > > > > > >Number: 31483 > > > >Category: bin > > > >Synopsis: minor correction in error message printed by acpiconf.8 > > > >Originator: Giorgos Keramidas > > > >Release: FreeBSD 5.0-CURRENT i386 > > > > [snip] > > > > > - err(1, NULL); > > > + err(1, ACPIDEV); > > > > Just as an idea.. err(1, "%s", ACPIDEV)? :) > > ACPIDEV is a #define'd constant string. It is not a security > vulnerability to use it as the original poster did. The original > poster's code is, > > err(1, "/dev/acpi"); > > By the time the compiler gets to it. No format string vulnerability. > > Anyway, here is a general err.h and sysexits.h cleanup of the program > that I'll commit if msmith and iwasaki don't mind, Thanks taking care of this, I don't mind so please commit :-) Thanks again To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200110251410.f9PEA2c29233>