Date: Thu, 21 Jun 2001 06:34:45 +0300 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Dima Dorfman <dima@unixfreak.org> Cc: freebsd-bugs@freebsd.org Subject: Re: kern/28297: change request for sys/i386/conf/NOTES Message-ID: <20010621063443.A9089@hades.hell.gr> In-Reply-To: <200106202220.f5KMK3x74622@freefall.freebsd.org>; from dima@unixfreak.org on Wed, Jun 20, 2001 at 03:20:03PM -0700 References: <200106202220.f5KMK3x74622@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 20, 2001 at 03:20:03PM -0700, Dima Dorfman wrote:
>
> Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
> >
> > >Number: 28297
> > >Category: kern
> > >Synopsis: change request for sys/i386/conf/NOTES
> > >Description:
> >
> > The NOTES file of 5.0-CURRENT (CVSup'ed yesterday, Tue Jun 19 2001),
> > says the following in the description of NTIMECOUNTER
> >
> > # The default is 5, there is no upper limit but more than a couple
> > # of hundred are not productive.
> >
> > But the value of NTIMECOUNTER in NOTES a few lines below is 20.
> >
> > options NTIMECOUNTER=20
> >
> > >Fix:
> >
> > Change either the description to match the default,
> > or the default to match the description.
>
> NOTES isn't supposed to set the variables to their defaults. NOTES is
> supposed to set variables to values *other* than the default to
> potentially catch places where the default is hardcoded in (which
> shouldn't be).
Yes, if NOTES is not supposed to set variables to their defaults, this
seems reasonable. Am sure we can close this PR in that case. The
comment seemed to indicate that this is the default though. Perhaps
we should reword the comment to read something like:
The default is 5, although you can set it to any other value (for
instance 20) as shown below.
-giorgos
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010621063443.A9089>