Date: Fri, 21 Jun 2024 15:42:24 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Thierry Thomas <thierry@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions Message-ID: <224470ebe4c1f9da0c394a33cfde261e@mail.infomaniak.com> In-Reply-To: <ZnVvwBGocIxc0K14@graf.pompo.net> References: <202406211115.45LBFt3m025401@gitrepo.freebsd.org> <74dfc79ede606f9424af2b0f564b01f3@mail.infomaniak.com> <ZnVvwBGocIxc0K14@graf.pompo.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-06-21T14:19:12.000+02:00, Thierry Thomas <thierry@freebsd.org> wrote: > Le ven. 21 juin 24 à 14:13:00 +0200, Daniel Engberg <daniel.engberg.lists@pyret.net> > > écrivait : > >> A bit cleaner and likely sustainable solution would be to import >> the >> >> CMake build from Fedora/Macports which would likely remove all >> the >> >> manual workarounds for upstream's Makefile. >> >> https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMakeLists.txt >> >> https://github.com/macports/macports-ports/blob/master/math/mathex/files/CMakeLists.txt > > Well, cmake is rather heavy, and it seems over-engineering to use it > for > > such a small library! > > -- > > Th. Thomas. The only consumer (not linked?) uses CMake too so I don't see that much of a concern? Here's a poc with prefix(ed) examples,matching comment (there a typo) and pkg-descr (slightly altered). Plist is also fixed when EXAMPLES are disabled (needs to be patched either way). https://projects.pyret.net/files/freebsd-patches/mathex-cmake.patch Best regards, Daniel [-- Attachment #2 --] <html><body><div>On 2024-06-21T14:19:12.000+02:00, Thierry Thomas <thierry@freebsd.org> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>Le ven. 21 juin 24 à 14:13:00 +0200, Daniel Engberg <<a href="mailto:daniel.engberg.lists@pyret.net" class="defaultMailLink">daniel.engberg.lists@pyret.net</a>><br></div><div> écrivait :<br></div><div><br></div><blockquote class="ws-ng-quote"><div> A bit cleaner and likely sustainable solution would be to import the<br></div><div> CMake build from Fedora/Macports which would likely remove all the<br></div><div> manual workarounds for upstream's Makefile.<br></div><div> <br></div><div> <a href="https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMakeLists.txt" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMakeLists.txt</a><br></div><div>; <br></div><div> <a href="https://github.com/macports/macports-ports/blob/master/math/mathex/files/CMakeLists.txt" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://github.com/macports/macports-ports/blob/master/math/mathex/files/CMakeLists.txt</a><br></div></blockquote><div>; <br></div><div>Well, cmake is rather heavy, and it seems over-engineering to use it for<br></div><div>such a small library!<br></div><div>-- <br></div><div>Th. Thomas.<br></div></pre></blockquote></div><div>The only consumer (not linked?) uses CMake too so I don't see that much of a concern? <br></div><div>Here's a poc with prefix(ed) examples,matching comment (there a typo) and pkg-descr (slightly altered).<br></div><div>Plist is also fixed when EXAMPLES are disabled (needs to be patched either way).<br></div><div><br></div><div><a href="https://projects.pyret.net/files/freebsd-patches/mathex-cmake.patch">https://projects.pyret.net/files/freebsd-patches/mathex-cmake.patch</a><br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?224470ebe4c1f9da0c394a33cfde261e>