Date: Tue, 6 Nov 2018 00:08:53 +0000 From: Alexander Richardson <arichardson@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340157 - in head: . tools/build tools/tools/nanobsd/embedded Message-ID: <CA%2BZ_v8ohQAYMt%2BZeQsE%2Bcgydt-20ud317xWZ0%2BF9tFgLexrhJg@mail.gmail.com> In-Reply-To: <6aa3fcb9-2199-4d80-a006-f72c59f499c3@FreeBSD.org> References: <201811051951.wA5JpB5q088141@repo.freebsd.org> <6aa3fcb9-2199-4d80-a006-f72c59f499c3@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 5 Nov 2018, 23:32 Bryan Drewery <bdrewery@freebsd.org wrote: > On 11/5/2018 11:51 AM, Alex Richardson wrote: > > Author: arichardson > > Date: Mon Nov 5 19:51:10 2018 > > New Revision: 340157 > > URL: https://svnweb.freebsd.org/changeset/base/340157 > > > > Log: > > Allow building world without inheriting $PATH > > > > This change has a summary that doesn't seem to match its change (to > build host tools for cross-os builds). > Does $PATH go into the build still or not? SYSTEM_COMPILER relies on > $PATH inheriting into the build. Bootstrapping of host tools does not change unless BOOTSTRAP_ALL_TOOLS is set on the make command line (this will be the default for cross-os builds but that still requires more changes). This patch only ensures that the required tools are symlinked into worldtmp. $PATH should only be inherited for the bootstrap-tools phase. I thought I had tested all variations of universe builds but it looks like I forgot to test on a SYSTEM_COMPILER machine so didn't notice it is needed there. This should be fixed in r340167. $PATH will now be inherited when using the system compiler or linker but otherwise the strict path will be used. In case I missed more cases: the new strict path behaviour can be disabled by setting BUILD_WITH_STRICT_TMPPATH=0. Sorry about any breakage. Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BZ_v8ohQAYMt%2BZeQsE%2Bcgydt-20ud317xWZ0%2BF9tFgLexrhJg>